Idle: test SearchDialog.py

[philwebster]

BPO	18410
Nosy	@terryjreedy, @ezio-melotti, @rovitotv
Files	idle_test_searchdialog.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2016-05-17.22:22:45.193>
created_at = <Date 2013-07-09.03:00:07.474>
labels = ['expert-IDLE', 'type-feature']
title = 'Idle: test SearchDialog.py'
updated_at = <Date 2016-05-17.22:35:52.558>
user = 'https://bugs.python.org/philwebster'

bugs.python.org fields:

activity = <Date 2016-05-17.22:35:52.558>
actor = 'python-dev'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2016-05-17.22:22:45.193>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2013-07-09.03:00:07.474>
creator = 'philwebster'
dependencies = []
files = ['34354']
hgrepos = []
issue_num = 18410
keywords = ['patch']
message_count = 6.0
messages = ['192713', '213149', '219527', '265779', '265780', '265782']
nosy_count = 7.0
nosy_names = ['terry.reedy', 'ezio.melotti', 'Todd.Rovito', 'westley.martinez', 'python-dev', 'JayKrish', 'philwebster']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue18410'
versions = ['Python 3.5', 'Python 3.6']

[philwebster]

Continuing the IDLE unittest framework from bpo-15392. Depends on bpo-18365.

[westleymartinez]

I've submitted a patch. It's not complete. The global functions for the SearchDialog module don't yet have tests because I'm not sure of what these functions are used for. I'd like for anyone to point me in the right direction for implementing those tests. Then there are two tests for the class's main methods.

I assume tests are needed for SearchDialogBase.py as well. Should those be in a separate module?

[terryjreedy]

bpo-18592 has a patch for SearchDialogBase.

[python-dev]

New changeset 2aee50cb27d0 by Terry Jan Reedy in branch '3.5':
Issue bpo-18410: Test IDLE's search dialog; original patch by Westley Martínez.
https://hg.python.org/cpython/rev/2aee50cb27d0

[terryjreedy]

I only made two changes to the test class itself: 1. move "requires('gui')" to the top to quit as soon as possible. 2. add "del class.root" to prevent exit error message.

Westley is already in misc.ACKS.

[python-dev]

New changeset a2cb99027646 by Terry Jan Reedy in branch '3.5':
Issue bpo-18410: add missing parent argument.
https://hg.python.org/cpython/rev/a2cb99027646