IDle: test textView.py

[philwebster]

BPO	18910
Nosy	@terryjreedy, @ned-deily, @rovitotv, @zware, @serhiy-storchaka
Files	test_textview.patch test_textview-18910.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2016-05-16.04:08:06.158>
created_at = <Date 2013-09-03.01:56:46.289>
labels = ['expert-IDLE', 'type-feature']
title = 'IDle: test textView.py'
updated_at = <Date 2016-05-16.04:08:06.112>
user = 'https://bugs.python.org/philwebster'

bugs.python.org fields:

activity = <Date 2016-05-16.04:08:06.112>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2016-05-16.04:08:06.158>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2013-09-03.01:56:46.289>
creator = 'philwebster'
dependencies = []
files = ['31569', '35488']
hgrepos = []
issue_num = 18910
keywords = ['patch']
message_count = 13.0
messages = ['196820', '219782', '219784', '219899', '219900', '219921', '219923', '219925', '220009', '220041', '220073', '265664', '265665']
nosy_count = 9.0
nosy_names = ['terry.reedy', 'ned.deily', 'Todd.Rovito', 'python-dev', 'zach.ware', 'serhiy.storchaka', 'JayKrish', 'philwebster', 'Saimadhav.Heblikar']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue18910'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5', 'Python 3.6']

[philwebster]

Started writing the tests for textView.py.

[python-dev]

New changeset 9ac57970ee4c by Terry Jan Reedy in branch '2.7':
Issue bpo-18910: Add unittest for textView. Patch by Phil Webster.
http://hg.python.org/cpython/rev/9ac57970ee4c

New changeset 99047f3a19a9 by Terry Jan Reedy in branch '3.4':
Issue bpo-18910: Add unittest for textView. Patch by Phil Webster.
http://hg.python.org/cpython/rev/99047f3a19a9

[terryjreedy]

The use of .__new__ was cute. Unfortunately, it did not backport to 2.7 because tkinter classes were never upgraded from old to new in 2.7 and old-style classes do not have .__new__. So I monkeypatched the module instead, which is a but clumbsier than patching the instance.
Though not every detail is tested, coverage is essentialy 100% and the human text covers the visual details.

[terryjreedy]

Since all tests create a widget with widgets (or destroy it), the new patch moves root to class scope and simplifies the code a bit. It also subclasses TextViewer instead of monkey-patching it. Modules have to be monkey-patched because they cannot be 'sub-moduled'.

[python-dev]

New changeset 86ba41b7bb46 by Terry Jan Reedy in branch '2.7':
Issue bpo-18910: test_textView - since all tests require 'gui', make root global.
http://hg.python.org/cpython/rev/86ba41b7bb46

New changeset 5a46ebfa5d90 by Terry Jan Reedy in branch '3.4':
Issue bpo-18910: test_textView - since all tests require 'gui', make root global.
http://hg.python.org/cpython/rev/5a46ebfa5d90

[ned-deily]

It looks like the 2.7 checkin has caused a number of buildbots to fail. Examples:

http://buildbot.python.org/all/builders/AMD64%20Ubuntu%20LTS%202.7/builds/1094/steps/test/logs/stdio

======================================================================
ERROR: idlelib.idle_test.test_textview (unittest.loader.ModuleImportFailure)
----------------------------------------------------------------------

ImportError: Failed to import test module: idlelib.idle_test.test_textview
Traceback (most recent call last):
  File "/opt/python/2.7.langa-ubuntu/build/Lib/unittest/loader.py", line 254, in _find_tests
    module = self._get_module_from_name(name)
  File "/opt/python/2.7.langa-ubuntu/build/Lib/unittest/loader.py", line 232, in _get_module_from_name
    __import__(name)
  File "/opt/python/2.7.langa-ubuntu/build/Lib/idlelib/idle_test/test_textview.py", line 11, in <module>
    requires('gui')
  File "/opt/python/2.7.langa-ubuntu/build/Lib/test/test_support.py", line 359, in requires
    raise ResourceDenied(_is_gui_available.reason)
ResourceDenied: Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]

and:

http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%202.7/builds/440/steps/test/logs/stdio

======================================================================
ERROR: idlelib.idle_test.test_textview (unittest.loader.ModuleImportFailure)
----------------------------------------------------------------------

ImportError: Failed to import test module: idlelib.idle_test.test_textview
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/2.7.murray-snowleopard/build/Lib/unittest/loader.py", line 254, in _find_tests
    module = self._get_module_from_name(name)
  File "/Users/buildbot/buildarea/2.7.murray-snowleopard/build/Lib/unittest/loader.py", line 232, in _get_module_from_name
    __import__(name)
  File "/Users/buildbot/buildarea/2.7.murray-snowleopard/build/Lib/idlelib/idle_test/test_textview.py", line 11, in <module>
    requires('gui')
  File "/Users/buildbot/buildarea/2.7.murray-snowleopard/build/Lib/test/test_support.py", line 359, in requires
    raise ResourceDenied(_is_gui_available.reason)
ResourceDenied: gui tests cannot run without OS X window manager

[serhiy-storchaka]

Please don't create Tk object at module creating stage. I afraid this will break unittest discoverity.

[terryjreedy]

The 3.4 stable buildbots are green except for two that ran test_idle ok.
The problem is that in 2.7, unittest.loader does not catch ResourceDenied at module level whereas is does in 3.4. The only indication that there should be a difference is that the 3.x doc has "Skipped modules will not have setUpModule() or tearDownModule() run."

I am puzzled though, since the manual says this was added in 3.1 and 2.7 came out after. Also, I presume that 2.7 test.regrtest honors the SkipTest raised by 2.7 test_support.import_module, which is usually used at module level.

If someone wants to revert the patch, go ahead. I have to get some sleep before I do anything (it is 5 am).

"Please don't create Tk object at module creating stage."
I didn't. I intentionally put TK stuff inside setUpModule so it would happen at test running stage.

[python-dev]

New changeset a0be81607a50 by Benjamin Peterson in branch '2.7':
backed out 86ba41b7bb46 (bpo-18910) for test breakage
http://hg.python.org/cpython/rev/a0be81607a50

[zware]

The changeset Benjamin backed out is pretty much fine, just needs the requires('gui') to be at the top of setUpModule instead of at toplevel. That does mean the whole module is constructed and then thrown away without doing anything, but it at least runs properly even with no Tk available.