Use argparse in the calendar module

[serhiy-storchaka]

BPO	18973
Nosy	@rhettinger, @bitdancer, @serhiy-storchaka, @matrixise, @vajrasky
Dependencies	bpo-18982: Add tests for CLI of the calendar module
Files	calendar_argparse.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2015-11-01.15:17:33.321>
created_at = <Date 2013-09-08.15:06:16.295>
labels = ['type-feature', 'library']
title = 'Use argparse in the calendar module'
updated_at = <Date 2015-11-01.15:18:40.918>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2015-11-01.15:18:40.918>
actor = 'matrixise'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2015-11-01.15:17:33.321>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2013-09-08.15:06:16.295>
creator = 'serhiy.storchaka'
dependencies = ['18982']
files = ['31670']
hgrepos = []
issue_num = 18973
keywords = ['patch']
message_count = 9.0
messages = ['197264', '197268', '197270', '197301', '197321', '253628', '253852', '253853', '253854']
nosy_count = 7.0
nosy_names = ['rhettinger', 'bethard', 'r.david.murray', 'python-dev', 'serhiy.storchaka', 'matrixise', 'vajrasky']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue18973'
versions = ['Python 3.6']

[serhiy-storchaka]

Here is a patch which replaces optparse to argparse in the calendar modules.

[vajrasky]

I don't see any patches. You forgot to upload the patch?

[serhiy-storchaka]

You forgot to upload the patch?

Again.

[bitdancer]

I think it is highly inadvisable to make changes like this without also adding tests. We broke compileall by doing this even though we *did* add tests.

[serhiy-storchaka]

Good point. See bpo-18982.

[matrixise]

Hi Serhiy,

I just reviewed your patch, works fine with 3.6.

[python-dev]

New changeset 9f8b5053e30d by Serhiy Storchaka in branch 'default':
Issue bpo-18973: Command-line interface of the calendar module now uses argparse
https://hg.python.org/cpython/rev/9f8b5053e30d

[serhiy-storchaka]

Thank you SilentGhost and Stéphane for your review.

[matrixise]

Serhiy, welcome.