Eliminate the use of the deprecated bundlebuilder.py script in OS X builds

[ericsnowcurrently]

BPO	20022
Nosy	@ronaldoussoren, @ned-deily, @ericsnowcurrently
Files	python-launcher-no-bundlebuilder.txt

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ned-deily'
closed_at = <Date 2014-03-30.06:59:52.873>
created_at = <Date 2013-12-19.04:13:34.189>
labels = ['type-feature']
title = 'Eliminate the use of the deprecated bundlebuilder.py script in OS X builds'
updated_at = <Date 2014-03-30.06:59:52.872>
user = 'https://github.com/ericsnowcurrently'

bugs.python.org fields:

activity = <Date 2014-03-30.06:59:52.872>
actor = 'ned.deily'
assignee = 'ned.deily'
closed = True
closed_date = <Date 2014-03-30.06:59:52.873>
closer = 'ned.deily'
components = []
creation = <Date 2013-12-19.04:13:34.189>
creator = 'eric.snow'
dependencies = []
files = ['33211']
hgrepos = []
issue_num = 20022
keywords = ['patch', 'needs review']
message_count = 5.0
messages = ['206578', '206591', '206609', '215172', '215173']
nosy_count = 4.0
nosy_names = ['ronaldoussoren', 'ned.deily', 'python-dev', 'eric.snow']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue20022'
versions = ['Python 3.5']

[ericsnowcurrently]

Mac/Tools/bundlebuilder.py uses deprecated imp APIs. It should be refactored to use the current import-related APIs.

[ned-deily]

bundlebuild.py is a deprecated legacy tool that has been superseded by the third-party py2app. AFAIK, its only use in Python 3 is to build PythonLauncher.app; it is not included in a Python installation. Rather than refactor it, its use should be eliminated in Mac/PythonLauncher/Makefile.in.

[ronaldoussoren]

Removing bundle builder should be easy enough if it is only used to create the PythonLauncher application bundle: that bundle does not contain python code at all and constructing it is just a matter of copying files to the right location.

The attached patch should do the trick. The patch is very rough, but does work.

[python-dev]

New changeset 3cf72994d5ae by Ned Deily in branch 'default':
Issue bpo-20022: Eliminate use of deprecated bundlebuilder in OS X builds.
http://hg.python.org/cpython/rev/3cf72994d5ae

[ned-deily]

Thanks for the patch, Ronald. I modified it a bit and also removed bundlebuilder.py from the source tree. Applied for release in 3.5.0.