Logging: RotatingFileHandler computes string length instead of byte representation length.

[alibotean]

BPO	20137
Nosy	@vsajip, @bitdancer
Files	rotatingfilehandler.py

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-02-05.22:01:55.693>
created_at = <Date 2014-01-06.09:19:31.638>
labels = ['invalid', 'type-bug', 'library']
title = 'Logging: RotatingFileHandler computes string length instead of byte representation length.'
updated_at = <Date 2014-02-05.22:01:55.692>
user = 'https://bugs.python.org/alibotean'

bugs.python.org fields:

activity = <Date 2014-02-05.22:01:55.692>
actor = 'vinay.sajip'
assignee = 'none'
closed = True
closed_date = <Date 2014-02-05.22:01:55.693>
closer = 'vinay.sajip'
components = ['Library (Lib)']
creation = <Date 2014-01-06.09:19:31.638>
creator = 'alibotean'
dependencies = []
files = ['33322']
hgrepos = []
issue_num = 20137
keywords = []
message_count = 5.0
messages = ['207417', '207447', '208023', '208055', '210348']
nosy_count = 3.0
nosy_names = ['vinay.sajip', 'r.david.murray', 'alibotean']
pr_nums = []
priority = 'normal'
resolution = 'not a bug'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue20137'
versions = ['Python 2.7']

[alibotean]

Current implementation of RotatingFileHandler ignores the encoding when computing the entry byte length.

I've attached a modified version that will compute the entry lenght in bytes.

[bitdancer]

Could you please upload your proposed fix as a patch file (universal diff)?

[alibotean]

Sure, will come back shortly with a patch.

[vsajip]

Which encoding are you using, such that the difference in length between encoded and decoded messages is significant?

[alibotean]

Which encoding are you using, such that the difference in length between encoded and decoded messages is significant?

I agree right off the bat that the error in size is not significant. Only the length of the last appended line is computed erroneously.

I'm uploading the patch in case you decide to apply it.

Thanks.