Remove dependency on tests.txt when running test_asyncio suite

[vajrasky]

BPO	20668
Nosy	@gvanrossum, @vstinner, @1st1, @vajrasky
Files	automatic_find_tests_inside_asyncio_test_suite.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/1st1'
closed_at = <Date 2014-03-27.16:22:00.358>
created_at = <Date 2014-02-18.04:45:42.525>
labels = ['type-bug', 'tests']
title = 'Remove dependency on tests.txt when running test_asyncio suite'
updated_at = <Date 2014-03-31.15:42:55.665>
user = 'https://github.com/vajrasky'

bugs.python.org fields:

activity = <Date 2014-03-31.15:42:55.665>
actor = 'python-dev'
assignee = 'yselivanov'
closed = True
closed_date = <Date 2014-03-27.16:22:00.358>
closer = 'python-dev'
components = ['Tests']
creation = <Date 2014-02-18.04:45:42.525>
creator = 'vajrasky'
dependencies = []
files = ['34129']
hgrepos = []
issue_num = 20668
keywords = ['patch']
message_count = 10.0
messages = ['211477', '211478', '211706', '211707', '214964', '214971', '214983', '214984', '215244', '215245']
nosy_count = 5.0
nosy_names = ['gvanrossum', 'vstinner', 'python-dev', 'yselivanov', 'vajrasky']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue20668'
versions = ['Python 3.4']

[vajrasky]

We can run the whole asyncio tests by using this command:
./python -m test.test_asyncio

But this way depends on the Lib/test/test_asyncio/tests.txt which contains all the tests that need to be executed. The problem is the core developer may forget to modify the tests.txt if he/she wants to add new test in asyncio test suite. Guido may not forget about it. But Victor forgot to modify the tests.txt when he added test_subprocess.py in asyncio tests suite.

So the proposed patch removes dependency on tests.txt file. When core developers add new test in asyncio tests suite, they just need to add the new file in test_asyncio directory itself. This patch was inspired by Lib/test/test_json/init.py.

[gvanrossum]

Thanks, LGTM. Please commit and add to bpo-20648.

[gvanrossum]

Please wait until after 3.4 release. Not critical.

On Wednesday, February 19, 2014, Yury Selivanov <report@bugs.python.org>
wrote:

Changes by Yury Selivanov <yselivanov.ml@gmail.com <javascript:;>>:

----------
nosy: +yselivanov

---

Python tracker <report@bugs.python.org <javascript:;>>
<http://bugs.python.org/issue20668\>

---

[1st1]

Please wait until after 3.4 release. Not critical.
I'll assign this to myself to commit this after 3.4.

[python-dev]

New changeset bcc77493249c by Yury Selivanov in branch 'default':
asyncio.tests: Autodiscover asyncio tests. Patch by Vajrasky Kok. Closes bpo-20668
http://hg.python.org/cpython/rev/bcc77493249c

[gvanrossum]

I think this is reasonable to also commit to the 3.4 branch so it will appear in 3.4.1.

[python-dev]

New changeset 07984815003f by Yury Selivanov in branch '3.4':
asyncio.tests: Autodiscover asyncio tests. Patch by Vajrasky Kok. Closes bpo-20668
http://hg.python.org/cpython/rev/07984815003f

[1st1]

Guido, good idea. Committed.

[vajrasky]

Thanks for committing my patch, Yury. But you forgot to remove Lib/test/test_asyncio/tests.txt.

[python-dev]

New changeset bf661f72aaab by Victor Stinner in branch '3.4':
Issue bpo-20668: Remove tests.txt of test_asyncio
http://hg.python.org/cpython/rev/bf661f72aaab

New changeset a76e459e09be by Victor Stinner in branch 'default':
(Merge 3.4) Issue bpo-20668: Remove tests.txt of test_asyncio
http://hg.python.org/cpython/rev/a76e459e09be