Typo in gzip._PaddedFile

[PCManticore]

BPO	20875
Nosy	@ned-deily, @PCManticore
Files	gzip_typo.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-03-09.21:49:51.849>
created_at = <Date 2014-03-09.19:40:15.544>
labels = ['type-bug', 'library']
title = 'Typo in gzip._PaddedFile'
updated_at = <Date 2014-03-09.21:49:51.822>
user = 'https://github.com/PCManticore'

bugs.python.org fields:

activity = <Date 2014-03-09.21:49:51.822>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2014-03-09.21:49:51.849>
closer = 'ned.deily'
components = ['Library (Lib)']
creation = <Date 2014-03-09.19:40:15.544>
creator = 'Claudiu.Popa'
dependencies = []
files = ['34312']
hgrepos = []
issue_num = 20875
keywords = ['patch']
message_count = 4.0
messages = ['212978', '212979', '212989', '212990']
nosy_count = 3.0
nosy_names = ['ned.deily', 'Claudiu.Popa', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue20875'
versions = ['Python 3.3', 'Python 3.4']

[PCManticore]

There's a typo in gzip._PaddedFile.prepend. Here's a snippet to reproduce it.

>>> import gzip
>>> x=gzip.open("a.gz")
>>> x.fileobj.prepend()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/tank/libs/cpython/Lib/gzip.py", line 99, in prepend
    self._buffer = self._buffer[read:] + prepend
NameError: name 'read' is not defined
>>>

[PCManticore]

Patch attached.

[python-dev]

New changeset c3836de644e0 by Ned Deily in branch '3.3':
Issue bpo-20875: Prevent possible gzip "'read' is not defined" NameError.
http://hg.python.org/cpython/rev/c3836de644e0

New changeset 42599de6a4de by Ned Deily in branch 'default':
Issue bpo-20875: Merge from 3.3
http://hg.python.org/cpython/rev/42599de6a4de

[ned-deily]

Thanks for the patch! Committed for release with 3.3.6 and 3.4.1.