Move test_namespace_pkgs into test_importlib.

[ericsnowcurrently]

BPO	21097
Nosy	@warsaw, @brettcannon, @ncoghlan, @ericvsmith, @ericsnowcurrently

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-03-29.22:16:44.276>
created_at = <Date 2014-03-29.21:21:24.847>
labels = ['type-feature']
title = 'Move test_namespace_pkgs into test_importlib.'
updated_at = <Date 2014-04-09.01:57:35.859>
user = 'https://github.com/ericsnowcurrently'

bugs.python.org fields:

activity = <Date 2014-04-09.01:57:35.859>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2014-03-29.22:16:44.276>
closer = 'eric.snow'
components = []
creation = <Date 2014-03-29.21:21:24.847>
creator = 'eric.snow'
dependencies = []
files = []
hgrepos = []
issue_num = 21097
keywords = []
message_count = 7.0
messages = ['215145', '215149', '215153', '215156', '215157', '215158', '215795']
nosy_count = 6.0
nosy_names = ['barry', 'brett.cannon', 'ncoghlan', 'eric.smith', 'python-dev', 'eric.snow']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21097'
versions = ['Python 3.4', 'Python 3.5']

[ericsnowcurrently]

While working on bpo-19711 it dawned on me that test_namespace_pkgs might be more appropriate as a submodule of test_importlib. The feature doesn't have it's own module nor is it otherwise independent of importlib.

I don't want to introduce churn here for the sake of conceptual purity. Rather, the module would be more discoverable if associated with importlib in this way. For bpo-19711 I wrote a test case that was overly complicated and did not work (goes hand-in-hand, no?) that I would not have spent time on if I'd remembered about test_namespace_pkgs or seen it somewhere under test_import*.

As a bonus, this change moves 1 file and 1 directory out of Lib/test (a directory that takes "flat is better than nested" to the extreme).

Any objections?

[ncoghlan]

Fine by me.

[ericvsmith]

Makes sense to me.

[python-dev]

New changeset 6d44bd8066ee by Eric Snow in branch 'default':
Issue bpo-21097: Move test_namespace_pkgs into test_importlib.
http://hg.python.org/cpython/rev/6d44bd8066ee

[python-dev]

New changeset 48790b202a50 by Eric Snow in branch '3.4':
Issue bpo-21097: Move test_namespace_pkgs into test_importlib.
http://hg.python.org/cpython/rev/48790b202a50

[ericsnowcurrently]

I seriously need to remember to apply to 3.4 and merge forward! :P

[python-dev]

New changeset 99265d30fa38 by Ned Deily in branch '3.4':
Issue bpo-21097: Update Makefile with changed install locations of test directories.
http://hg.python.org/cpython/rev/99265d30fa38

New changeset 7aae2b9fcfad by Ned Deily in branch 'default':
Issue bpo-21097: merge from 3.4
http://hg.python.org/cpython/rev/7aae2b9fcfad