logging configurators ignoring documented options

[JureKoren]

BPO	21203
Nosy	@vsajip
Files	logging_config_2_7.diff: patch for 2.7 logging_config_default.diff: patch for default

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-04-15.13:25:05.268>
created_at = <Date 2014-04-11.21:39:27.963>
labels = ['type-bug', 'library']
title = 'logging configurators ignoring documented options'
updated_at = <Date 2014-04-15.16:05:12.551>
user = 'https://bugs.python.org/JureKoren'

bugs.python.org fields:

activity = <Date 2014-04-15.16:05:12.551>
actor = 'Jure.Koren'
assignee = 'none'
closed = True
closed_date = <Date 2014-04-15.13:25:05.268>
closer = 'python-dev'
components = ['Library (Lib)']
creation = <Date 2014-04-11.21:39:27.963>
creator = 'Jure.Koren'
dependencies = []
files = ['34787', '34788']
hgrepos = ['233', '234']
issue_num = 21203
keywords = ['patch']
message_count = 5.0
messages = ['215954', '215955', '216287', '216288', '216326']
nosy_count = 3.0
nosy_names = ['vinay.sajip', 'python-dev', 'Jure.Koren']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue21203'
versions = ['Python 3.5']

[JureKoren]

2.7's logging.config.DictConfig does not respect the "class" option, but fileConfig does.

The default branch logging.config has the same problem in DictConfig, but also lacks "style" support in fileConfig.

[JureKoren]

2.7's logging.config.DictConfig does not respect the "class" option, but fileConfig does.

The default branch logging.config has the same problem in DictConfig, but also lacks "style" support in fileConfig.

[vsajip]

I'm not sure I can accept the change in 2.7, because it is technically a new feature and would mean that configs would not be treated the same way in all 2.7.x versions failing in some and not in others. You can get the equivalent behaviour using '()' rather than 'class', and the 'class' keyword is only mentioned in the docs against Handlers, not Formatters.

The patch for the default branch looks OK. Thanks!

[python-dev]

New changeset 2d33cbf02522 by Vinay Sajip in branch 'default':
Closes bpo-21203: Updated fileConfig and dictConfig to remove inconsistencies. Thanks to Jure Koren for the patch.
http://hg.python.org/cpython/rev/2d33cbf02522

[JureKoren]

I agree about the 2.7 branch, I did that one off the top of my head after struggling with backporting the code to 2.7.