patch to use cabinet.lib instead of fci.lib (fixes build with Windows SDK 8.0)

[mst]

BPO	21236
Nosy	@loewis, @zware, @zooba

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2014-12-18.18:44:07.668>
created_at = <Date 2014-04-15.15:33:35.921>
labels = ['build', 'OS-windows']
title = 'patch to use cabinet.lib instead of fci.lib (fixes build with Windows SDK 8.0)'
updated_at = <Date 2014-12-18.18:44:07.667>
user = 'https://bugs.python.org/mst'

bugs.python.org fields:

activity = <Date 2014-12-18.18:44:07.667>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2014-12-18.18:44:07.668>
closer = 'steve.dower'
components = ['Build', 'Windows']
creation = <Date 2014-04-15.15:33:35.921>
creator = 'mst'
dependencies = []
files = []
hgrepos = []
issue_num = 21236
keywords = []
message_count = 5.0
messages = ['216309', '231636', '231639', '231875', '232898']
nosy_count = 4.0
nosy_names = ['loewis', 'zach.ware', 'steve.dower', 'mst']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue21236'
versions = ['Python 3.5']

[mst]

building with MSVC2012 and the Windows SDK 8.0 fails

according to this page, the fci.lib is no longer available
and cabinet.lib should be used instead:

http://social.msdn.microsoft.com/Forums/en-US/vcgeneral/thread/3b85f36e-dffe-4589-adc3-13673b349812/

"For Windows 8 onward fci.lib and fdi.lib will become private internal libraries and will not included in Windows SDK"

here is a patch to do that:
http://cgit.freedesktop.org/libreoffice/core/tree/external/python3/python-3.3.0-msvc2012.patch.1

the author of the patch is Peter Foley.

[zooba]

I've inadvertently picked this up with my changes for bpo-22919, so it'll get into 3.5 that way.

Do we need to apply this to 3.4 as well? What about 2.7?

[zware]

Definitely not 2.7, since it's still on VS2008 and would require so many changes for this to matter that it's just not an issue; I'm not sure on 3.4. Is cabinet.lib available (and have everything we need) for MSVC10 and SDK 7.1 (which are the important targets for 3.4)?

[zooba]

AFAICT, cabinet.lib has been around since at least VS 2008, so 3.4 will be fine. But since it builds currently there's no point changing it. I'll just let my changes handle it for 3.5 and leave the older versions alone.

[zooba]

This was fixed with bpo-22919.