define PATH_MAX for GNU/Hurd in Python/pythonrun.c

[doko42]

BPO	21274
Nosy	@loewis, @Yhg1s, @doko42, @vstinner, @berkerpeksag
Files	hurd-path_max.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-04-16.17:34:15.817>
created_at = <Date 2014-04-16.22:32:56.136>
labels = ['interpreter-core']
title = 'define PATH_MAX for GNU/Hurd in Python/pythonrun.c'
updated_at = <Date 2016-04-16.17:34:15.725>
user = 'https://github.com/doko42'

bugs.python.org fields:

activity = <Date 2016-04-16.17:34:15.725>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2016-04-16.17:34:15.817>
closer = 'berker.peksag'
components = ['Interpreter Core']
creation = <Date 2014-04-16.22:32:56.136>
creator = 'doko'
dependencies = []
files = ['34933']
hgrepos = []
issue_num = 21274
keywords = ['patch']
message_count = 8.0
messages = ['216611', '216712', '216718', '216723', '230663', '230680', '230683', '263568']
nosy_count = 6.0
nosy_names = ['loewis', 'twouters', 'doko', 'vstinner', 'python-dev', 'berker.peksag']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue21274'
versions = ['Python 3.4', 'Python 3.5']

[doko42]

PATH_MAX is not defined on GNU/Hurd. Take the same approach as taken for Windows in the very same file and define it in terms of MAXPATHLEN.

[Yhg1s]

You should put the definition closer to the Windows one (right after or before it) rather than further down the file. Other than that, looks good.

[python-dev]

New changeset ca2edbefca35 by doko in branch '3.4':
Fixes for KFreeBSD and the Hurd:
http://hg.python.org/cpython/rev/ca2edbefca35

[doko42]

fixed

[loewis]

Reopening. What problem does this fix? AFAICT, PATH_MAX isn't used at all (anymore).

[python-dev]

New changeset d6fb87972dee by Victor Stinner in branch 'default':
Issue bpo-20597, bpo-21274: Remove unused definition of PATH_MAX on GNU/Hurd,
https://hg.python.org/cpython/rev/d6fb87972dee

[vstinner]

In Python 3.5, PATH_MAX is no more used in Modules/main.c nor Python/pythonrun.c. I removed the "#define PATH_MAX ..." on Hurd.

I didn't check Python 3.4.

[berkerpeksag]

Python 3.4 is in security-fix-only mode so we can close this now.