refactor and fix curses configure checks

[doko42]

BPO	21285
Nosy	@Yhg1s, @doko42, @vstinner
Files	ncurses-configure.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-04-17.20:12:21.769>
created_at = <Date 2014-04-17.16:04:16.187>
labels = ['build']
title = 'refactor and fix curses configure checks'
updated_at = <Date 2014-04-17.20:12:21.768>
user = 'https://github.com/doko42'

bugs.python.org fields:

activity = <Date 2014-04-17.20:12:21.768>
actor = 'doko'
assignee = 'none'
closed = True
closed_date = <Date 2014-04-17.20:12:21.769>
closer = 'doko'
components = ['Build']
creation = <Date 2014-04-17.16:04:16.187>
creator = 'doko'
dependencies = []
files = ['34949']
hgrepos = []
issue_num = 21285
keywords = ['patch']
message_count = 5.0
messages = ['216704', '216719', '216721', '216722', '216736']
nosy_count = 4.0
nosy_names = ['twouters', 'doko', 'vstinner', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue21285'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']

[doko42]

this refactors the curses configure checks, and fixes the build with ncursesw. In it's current form the curses feature checks are run without the additional include path which leads to wrong results if the only the nurses headers are installed.

[Yhg1s]

Good fix. Do remove the 'first curses header check' comment you add, and don't forget to regenerate configure (and maybe pyconfig.h.in? I don't know if that'll change.)

[python-dev]

New changeset 1bc0a8310b9f by doko in branch '2.7':

• Issue bpo-21285: Refactor and fix curses configure check to always search
  http://hg.python.org/cpython/rev/1bc0a8310b9f

New changeset 635817da596d by doko in branch '3.4':

• Issue bpo-21285: Refactor and fix curses configure check to always search
  http://hg.python.org/cpython/rev/635817da596d

[doko42]

looks like with this change the curses extension isn't built anymore on Solaris.

[doko42]

Victor pointer out the Solaris issue is unrelated. See bpo-13552. Closing.