Update thread_foobar.h to include timed locking and TLS support

[JackMc]

BPO	21312
Nosy	@tim-one, @pitrou, @JackMc
Files	update_thread_foobar.diff update_thread_foobar_v2.diff update_thread_foobar_v3.diff update_thread_foobar_v4.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-04-28.19:13:13.521>
created_at = <Date 2014-04-19.17:30:33.178>
labels = ['interpreter-core', 'type-feature']
title = 'Update thread_foobar.h to include timed locking and TLS support'
updated_at = <Date 2014-04-28.19:13:13.520>
user = 'https://github.com/JackMc'

bugs.python.org fields:

activity = <Date 2014-04-28.19:13:13.520>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2014-04-28.19:13:13.521>
closer = 'pitrou'
components = ['Interpreter Core']
creation = <Date 2014-04-19.17:30:33.178>
creator = 'Jack.McCracken'
dependencies = []
files = ['34974', '34975', '34976', '34977']
hgrepos = []
issue_num = 21312
keywords = ['patch']
message_count = 9.0
messages = ['216867', '216868', '216869', '216870', '216871', '216872', '216873', '217397', '217398']
nosy_count = 4.0
nosy_names = ['tim.peters', 'pitrou', 'python-dev', 'Jack.McCracken']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21312'
versions = ['Python 3.5']

[JackMc]

The thread_foobar.h reference for the interface for abstracting the platform-specific thread implementation does not include newer features such as timed locking and TLS support.

[JackMc]

Missed a word in a comment

[pitrou]

You may want to provide an implementation of PyThread_acquire_lock() that simply defers to PyThread_acquire_lock_timed() (see thread_pthread.h, which does the same).

[JackMc]

Added an example of deferring to PyThread_acquire_lock_timed in PyThread_acquire_lock. Also fixed a mistake in the string of a dprintf in PyThread_acquire_lock_timed.

[pitrou]

Hum, your comment about deferring is wrong, since thread_nt.h also does the deferring:

int
PyThread_acquire_lock(PyThread_type_lock aLock, int waitflag)
{
    return PyThread_acquire_lock_timed(aLock, waitflag ? -1 : 0, 0);
}

[JackMc]

Oops... I removed that and just put the deferral in there.

[pitrou]

Thanks! The patch looks good to me, I'll let it sleep a bit to see if other people have an opinion.

[python-dev]

New changeset 7bb1bda5dcef by Antoine Pitrou in branch 'default':
Issue bpo-21312: Update the thread_foobar.h template file to include newer threading APIs. Patch by Jack McCracken.
http://hg.python.org/cpython/rev/7bb1bda5dcef

[pitrou]

Ok, noone chimed in, so I committed the patch :-)
Thank you very much for your contribution!