skip 2 tests in test_urllib2net.py if _ssl module not present

[rpointel]

BPO	21456
Nosy	@pitrou, @berkerpeksag
Files	Lib_test_test_urllib2net_py.diff: diff to skip 2 tests in Lib/test/test_urllib2net.py if ssl module not present Lib_test_test_urllib2net_py.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/berkerpeksag'
closed_at = <Date 2014-10-10.11:36:37.452>
created_at = <Date 2014-05-09.07:03:50.306>
labels = ['type-bug', 'tests']
title = 'skip 2 tests in test_urllib2net.py if _ssl module not present'
updated_at = <Date 2014-10-10.11:36:37.450>
user = 'https://bugs.python.org/rpointel'

bugs.python.org fields:

activity = <Date 2014-10-10.11:36:37.450>
actor = 'berker.peksag'
assignee = 'berker.peksag'
closed = True
closed_date = <Date 2014-10-10.11:36:37.452>
closer = 'berker.peksag'
components = ['Tests']
creation = <Date 2014-05-09.07:03:50.306>
creator = 'rpointel'
dependencies = []
files = ['35192', '35505']
hgrepos = []
issue_num = 21456
keywords = ['patch']
message_count = 5.0
messages = ['218139', '218152', '219918', '228985', '228987']
nosy_count = 4.0
nosy_names = ['pitrou', 'python-dev', 'rpointel', 'berker.peksag']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue21456'
versions = ['Python 3.4', 'Python 3.5']

[rpointel]

Hi,

I tested the regress tests on a machine which does not have the ssl module, and I have 2 errors in Lib/test/test_urllib2net.py. I think it should skip the test instead.

Attached is a diff I wrote, it's based on Lib/test/test_poplib.py.

Don't hesitate if I miss a thing.

Remi.

[pitrou]

There isn't much point in introducing a variable named SUPPORTS_SSL, just use "ssl is not None".

[rpointel]

Are you ok with this diff reworked?

[python-dev]

New changeset ac55331c1df6 by Berker Peksag in branch '3.4':
Issue bpo-21456: Skip two tests in test_urllib2net.py if _ssl module not present.
https://hg.python.org/cpython/rev/ac55331c1df6

New changeset 470ea66f5bee by Berker Peksag in branch 'default':
Issue bpo-21456: Skip two tests in test_urllib2net.py if _ssl module not present.
https://hg.python.org/cpython/rev/470ea66f5bee

[berkerpeksag]

Thanks for the patch, Remi.