httplib client/server status refactor

[demianbrecht]

BPO	21793
Nosy	@warsaw, @rhettinger, @orsenthil, @bitdancer, @ethanfurman, @berkerpeksag, @vadmium, @serhiy-storchaka, @demianbrecht
Files	refactor_http_status_codes.patch refactor_http_status_codes_1.patch issue21793.patch issue21793_1.patch issue21793_2.patch issue21793_3.patch issue21793_4.patch issue21793_5.patch issue21793_6.patch issue21793_logfix.patch issue21793_logfix_1.patch issue21793_logfix_2.patch issue21793_logfix_3.patch issue21793_logfix_4.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2015-03-07.09:55:30.642>
created_at = <Date 2014-06-17.19:02:36.681>
labels = ['type-feature', 'library']
title = 'httplib client/server status refactor'
updated_at = <Date 2015-03-07.10:33:57.116>
user = 'https://github.com/demianbrecht'

bugs.python.org fields:

activity = <Date 2015-03-07.10:33:57.116>
actor = 'berker.peksag'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2015-03-07.09:55:30.642>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2014-06-17.19:02:36.681>
creator = 'demian.brecht'
dependencies = []
files = ['35672', '35680', '35708', '35711', '36012', '37368', '37370', '37420', '37434', '38068', '38084', '38191', '38193', '38197']
hgrepos = []
issue_num = 21793
keywords = ['patch']
message_count = 32.0
messages = ['220860', '220890', '220924', '221097', '221110', '223088', '223603', '232171', '232176', '232198', '232509', '232588', '233046', '233047', '235547', '235560', '235638', '235651', '235690', '235712', '235738', '236281', '236284', '236304', '236340', '236341', '236342', '236347', '236349', '236370', '237431', '237432']
nosy_count = 10.0
nosy_names = ['barry', 'rhettinger', 'orsenthil', 'r.david.murray', 'ethan.furman', 'python-dev', 'berker.peksag', 'martin.panter', 'serhiy.storchaka', 'demian.brecht']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21793'
versions = ['Python 3.5']

[demianbrecht]

This patch is a follow up to an out of scope comment made by R. David Murray in bpo-20898 (http://bugs.python.org/issue20898#msg213771).

In a nutshell, there is some redundancy between http.client and http.server insofar as the definition of http status code, names and descriptions go. The included patch is a stab at cleaning some of this up while remaining backwards compatible and is intended to solicit feedback before finishing work.

TODOs:

• Populate descriptions for status codes
• Documentation
• Tests (?)

[ethanfurman]

Left comments in reitvald about modifying the Enum used -- let me know if you have any questions about that.

[demianbrecht]

Attached new patch with changes from review and a stab at an update to the docs.

[demianbrecht]

New patch attached addressing review comments.

[demianbrecht]

Updated patch with silly missed doc update.

[demianbrecht]

Bump for a follow-up review or merge

[demianbrecht]

Removed draft status code, removed S from VARIANTS_

[demianbrecht]

Bump (again) for hopeful merge.

[berkerpeksag]

I left a couple of comments on Rietveld. Thanks for the patch, Demian.

[demianbrecht]

Updated patch addressing review comments. Thanks for the review.

[demianbrecht]

Self review/update: removed two errant breakpoints and updated the what's new section (missed in my previous patch).