Add Python implementation of FileIO

[serhiy-storchaka]

BPO	21859
Nosy	@pitrou, @vstinner, @benjaminp, @alex, @vadmium, @serhiy-storchaka
Dependencies	bpo-23668: Support os.ftruncate on Windows
Files	pyio_fileio.patch pyio_fileio_2.patch pyio_fileio_3.patch pyio_fileio_4.patch pyio_fileio_5.patch pyio_fileio_6.patch pyio_fileio_7.patch pyio_fileio_8.patch pyio_fileio_9.patch pyio_fileio_10.patch pyio_fileio_fix.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2015-05-12.11:06:09.075>
created_at = <Date 2014-06-24.11:06:53.860>
labels = ['type-feature', 'library', 'expert-IO']
title = 'Add Python implementation of FileIO'
updated_at = <Date 2015-05-12.11:06:09.073>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2015-05-12.11:06:09.073>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2015-05-12.11:06:09.075>
closer = 'serhiy.storchaka'
components = ['Library (Lib)', 'IO']
creation = <Date 2014-06-24.11:06:53.860>
creator = 'serhiy.storchaka'
dependencies = ['23668']
files = ['35769', '35858', '35871', '36032', '36183', '36782', '38651', '38653', '38885', '38888', '38889']
hgrepos = []
issue_num = 21859
keywords = ['patch']
message_count = 21.0
messages = ['221449', '222303', '222375', '223659', '224446', '228240', '239004', '239012', '239046', '239071', '240390', '240402', '240412', '240415', '240416', '240420', '240421', '240429', '240430', '240437', '242961']
nosy_count = 9.0
nosy_names = ['pitrou', 'vstinner', 'benjamin.peterson', 'stutzbach', 'alex', 'python-dev', 'martin.panter', 'piotr.dobrogost', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21859'
versions = ['Python 3.5']

[serhiy-storchaka]

Proposed patch adds Python implementation of FileIO in _pyio. This will help to make io and _pyio dependency on _io optional (bpo-17984).

[serhiy-storchaka]

Updated patch has included recent changes from C implementation (bpo-21679 and bpo-21090).

[serhiy-storchaka]

Many thanks Victor for your review. Updated patch addresses your comments. It also fixes debugging remnants in test_file_eintr.

[serhiy-storchaka]

Next iteration of the patch addressed Victor's comments.

[serhiy-storchaka]

Next iteration of the patch addressed Victor's and Akira's comments.

[serhiy-storchaka]

Synchronized with the tip. _io.FileIO now behave same as _pyio,FileIO when there is a NUL in name.

[serhiy-storchaka]

Updated to the tip (added the closefd attribute in repr). os.fstat() is now called only once in the constructor.

[serhiy-storchaka]

Restored first os.fstat() (however it now is redundant) and addressed most other Victor's comments.

In general I prefer EAFP over BDFL, and often "except AttributeError" looks better to me than getattr().

[vstinner]

I opened the issue bpo-23752: "Cleanup io.FileIO".

[vstinner]

New issue bpo-23754: "Add a new os.read_into() function to avoid memory copies".

[vstinner]

What's the status of the patch? Is it ready to be commited?

[serhiy-storchaka]

Removed redundant fstat() call (as in bpo-23752). Slightly corrected docstrings (but for larger changes C and Python implementations should be changed consistently).

I wait only for your approval Victor.