relpath: Provide better errors when mixing bytes and strings

[bachmann1234]

BPO	21883
Nosy	@serhiy-storchaka, @Bachmann1234
Files	error_message.patch os_path_typeerrors.patch os_path_typeerrors_2.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2014-10-04.12:12:37.769>
created_at = <Date 2014-06-30.03:12:55.869>
labels = ['type-feature', 'library']
title = 'relpath: Provide better errors when mixing bytes and strings'
updated_at = <Date 2014-10-04.13:18:52.070>
user = 'https://github.com/bachmann1234'

bugs.python.org fields:

activity = <Date 2014-10-04.13:18:52.070>
actor = 'python-dev'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2014-10-04.12:12:37.769>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2014-06-30.03:12:55.869>
creator = 'Matt.Bachmann'
dependencies = []
files = ['35806', '36743', '36744']
hgrepos = []
issue_num = 21883
keywords = ['patch']
message_count = 6.0
messages = ['221939', '221940', '227668', '227671', '228449', '228457']
nosy_count = 3.0
nosy_names = ['python-dev', 'serhiy.storchaka', 'Matt.Bachmann']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21883'
versions = ['Python 3.5']

[bachmann1234]

Howdy!

I encountered this error when accidently passing in mixed types to reldir

>>> import os
>>> os.path.relpath('/Users/bachmann', b'.')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/Cellar/python3/3.4.1/Frameworks/Python.framework/Versions/3.4/lib/python3.4/posixpath.py", line 451, in relpath
    start_list = [x for x in abspath(start).split(sep) if x]
TypeError: Type str doesn't support the buffer API

When this mistake is done in join we get a helpful error message.

I simply borrowed this logic and put in in relpath. Is this useful?

[bachmann1234]

Includes change and tests.

The test is similar so I just broke out the logic

[serhiy-storchaka]

Error message for posixpath.join() was fixed and enhanced in bpo-22034. Here is a patch which extends this enhancement to relpath() and to other os.path implementations (ntpath and macpath).

[serhiy-storchaka]

Ah, tests fail when Python runs without the -bb option. Here is fixed path.

[python-dev]

New changeset 2ba2ee5713bd by Serhiy Storchaka in branch 'default':
Issue bpo-21883: os.path.join() and os.path.relpath() now raise a TypeError with
https://hg.python.org/cpython/rev/2ba2ee5713bd

[python-dev]

New changeset 85de13b746ac by Serhiy Storchaka in branch 'default':
Fixed tests on Windows for issue bpo-21883.
https://hg.python.org/cpython/rev/85de13b746ac