Create unit tests for turtle textonly

[ingrid]

BPO	21916
Nosy	@tjguk, @bitdancer, @serhiy-storchaka, @JelleZijlstra
Files	test_turtle_textonly.patch test_turtle_textonly.patch test_turtle.patch test_turtle.patch issue21916-cr.patch: new patch adding test_turtle.py issue21916-cr2.patch issue21916-more.patch: patch with more Vec2D tests issue21916-more-cr.patch: patch addressing code review comments

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-06-05.07:39:19.542>
created_at = <Date 2014-07-04.13:12:44.626>
labels = ['type-feature', 'tests']
title = 'Create unit tests for turtle textonly'
updated_at = <Date 2016-06-05.07:39:19.541>
user = 'https://bugs.python.org/ingrid'

bugs.python.org fields:

activity = <Date 2016-06-05.07:39:19.541>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2016-06-05.07:39:19.542>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2014-07-04.13:12:44.626>
creator = 'ingrid'
dependencies = []
files = ['35856', '38950', '39018', '39458', '43199', '43202', '43216', '43228']
hgrepos = []
issue_num = 21916
keywords = ['patch', 'needs review']
message_count = 23.0
messages = ['222282', '240726', '240832', '241014', '243774', '243775', '243776', '243778', '243779', '243781', '243786', '267271', '267289', '267290', '267312', '267314', '267315', '267332', '267349', '267378', '267387', '267397', '267398']
nosy_count = 9.0
nosy_names = ['tim.golden', 'r.david.murray', 'jesstess', 'python-dev', 'serhiy.storchaka', 'ingrid', 'arachnegl', 'gregoryloyse@gmail.com', 'JelleZijlstra']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21916'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']

[ingrid]

Non-gui tests for turtle that Lita and I wrote.

[arachnegl]

Patch reviewed. Looks good.

This patch includes some amendments for readablity and new tests.

[bitdancer]

I made some review comments on ways to use test.support and test.subTest to simplify the code and make it even clearer. Also, I suggest not using Mock unless necessary (see review comments).

[arachnegl]

Thanks David for your review!

I have added a new patch in response.

Note the file has a new name

[tjguk]

Tests failed on Windows probably because of NamedTemporaryFile

[gregoryloysegmailcom]

Thanks Tim for testing on Windows and suggesting the change.

[tjguk]

@rdm I'm sitting with Greg at a London Python session and we've run through these tests on 3.4/3.5. I know you were reviewing this code at PyCon. Are you happy for me to commit from here?

[serhiy-storchaka]

I'm making a review.

[bitdancer]

Yes, I don't need to be involved further (unless you need help from me on something :)

[tjguk]

Serhiy's offered a review and we can take it from here. :)

[serhiy-storchaka]

Added comments on Rietveld.

It looks the patch includes changes for non-relevant files.

[JelleZijlstra]

This patch removes the unrelated XML changes and addresses most of the code review comments.

[serhiy-storchaka]

Added few minor comments on Rietveld. Please use more complex example for invalid config. Add valid lines before and after an invalid line.