IDLE - Test Percolator

[SaimadhavHeblikar]

BPO	21939
Nosy	@terryjreedy, @taleinat
Files	test_percolator-34.diff test_percolator-34-v2.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2016-05-18.02:54:50.771>
created_at = <Date 2014-07-08.14:19:46.215>
labels = ['expert-IDLE', 'type-feature']
title = 'IDLE - Test Percolator'
updated_at = <Date 2016-05-18.02:54:50.769>
user = 'https://bugs.python.org/SaimadhavHeblikar'

bugs.python.org fields:

activity = <Date 2016-05-18.02:54:50.769>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2016-05-18.02:54:50.771>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2014-07-08.14:19:46.215>
creator = 'Saimadhav.Heblikar'
dependencies = []
files = ['35899', '35982']
hgrepos = []
issue_num = 21939
keywords = ['patch']
message_count = 4.0
messages = ['222561', '222730', '265800', '265801']
nosy_count = 5.0
nosy_names = ['terry.reedy', 'taleinat', 'jesstess', 'python-dev', 'Saimadhav.Heblikar']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21939'
versions = ['Python 3.5', 'Python 3.6']

[SaimadhavHeblikar]

Attached is a unittest for idlelib.Percolator.
2.7 version will be added once this is OK.

[taleinat]

I've reviewed the patch and made my remarks in the review tool.

These tests don't test the central functionality of Percolator nearly enough. We should test, at least:

1. That the text actually went through the filter (and not directly to the Text
   widget).
2. That if a filter modifies the text, the modified text appears in the Text
   widget.
3. That a filter can stop the event from continuing through the following
   filters.
4. That having more than one filter modify the arguments works.
5. That not having any filters works.
6. That this doesn't only work on a Text widget's "insert" and "delete" events.

There are probably more things we should test. Take a look at what this is used
for in practice in the code for ideas.

[python-dev]

New changeset eebccf05903e by Terry Jan Reedy in branch '3.5':
Issue bpo-21939: Test IDLE percolator. Original patch by Saimadhav Heblikar.
https://hg.python.org/cpython/rev/eebccf05903e

[terryjreedy]

Tal, thanks for the suggestions. Saimadhav added tests for at least some of them. Part of the difficulty in adding IDLE tests is that it is too easy to write tests to the code instead of the use of the code. This is especially true when side-effects (changing a widget) are the main intended effect. I plan to work more on the latter.