`Dis` module doesn't know how to disassemble generators

[httpsgithubcomhakril]

BPO	21947
Nosy	@rhettinger, @ncoghlan, @pitrou, @vstinner, @https://github.com/hakril
Files	dis_generator.patch: patch for Lib/dis.py for generator disassembling dis_generator2.patch: patch with unit test and doc update dis_generator3.patch: Updated the docstrings of modified functions

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-07-25.13:09:09.277>
created_at = <Date 2014-07-09.14:28:29.287>
labels = ['extension-modules', 'type-feature']
title = "`Dis` module doesn't know how to disassemble generators"
updated_at = <Date 2014-07-25.13:09:09.277>
user = 'https://github.com/httpsgithubcomhakril'

bugs.python.org fields:

activity = <Date 2014-07-25.13:09:09.277>
actor = 'ncoghlan'
assignee = 'none'
closed = True
closed_date = <Date 2014-07-25.13:09:09.277>
closer = 'ncoghlan'
components = ['Extension Modules']
creation = <Date 2014-07-09.14:28:29.287>
creator = 'hakril'
dependencies = []
files = ['35914', '35918', '35954']
hgrepos = []
issue_num = 21947
keywords = ['patch']
message_count = 7.0
messages = ['222619', '222637', '222642', '222650', '223030', '223943', '223944']
nosy_count = 6.0
nosy_names = ['rhettinger', 'ncoghlan', 'pitrou', 'vstinner', 'python-dev', 'hakril']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue21947'
versions = ['Python 3.5']

[httpsgithubcomhakril]

The dis module doesn't know how to disassemble generator object because it has no idea about the gi_code attribute.
I made a (very) little patch to change this behavior.

If there is a valid reason to not let the dis module disassemble generator, I would be glad to know it.

[pitrou]

That sounds like a good idea. The patch lacks a unit test, though.

[httpsgithubcomhakril]

Here is a try for a better patch.
Added a unit test and updated the doc.

[rhettinger]

+1

[httpsgithubcomhakril]

Updated some docstrings in the new patch after the review comments.
Thanks kushou for the code review.

[python-dev]

New changeset 2ae5709692ef by Nick Coghlan in branch 'default':
Issue bpo-21947: handle generator-iterator objects in dis
http://hg.python.org/cpython/rev/2ae5709692ef

[ncoghlan]

Thanks for the patch Clement!

Could I also please request that you sign the Contributor License Agreement at https://www.python.org/psf/contrib/contrib-form/

While we have some discretion to accept "small" patches without one, a signed CLA helps assure that we have the necessary rights to incorporate and redistribute contributions worldwide.