Ensure in PyType_Ready() that base class of static type is static

[serhiy-storchaka]

BPO	22079
Nosy	@doko42, @pitrou, @scoder, @vstinner, @alex, @encukou, @serhiy-storchaka, @jdemeyer, @zhangyangyu
Files	issue22079.patch issue22079-tp_bases.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = None
created_at = <Date 2014-07-26.12:36:39.011>
labels = ['interpreter-core', 'type-feature']
title = 'Ensure in PyType_Ready() that base class of static type is static'
updated_at = <Date 2022-01-24.12:23:03.373>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2022-01-24.12:23:03.373>
actor = 'petr.viktorin'
assignee = 'serhiy.storchaka'
closed = False
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2014-07-26.12:36:39.011>
creator = 'serhiy.storchaka'
dependencies = []
files = ['37211', '43541']
hgrepos = []
issue_num = 22079
keywords = ['patch', 'needs review']
message_count = 26.0
messages = ['224049', '224102', '224103', '224110', '231277', '231579', '234852', '234876', '236807', '236830', '238881', '269188', '269195', '269223', '269247', '269275', '269278', '269279', '269291', '269339', '326321', '368736', '368743', '391446', '391464', '411469']
nosy_count = 11.0
nosy_names = ['doko', 'pitrou', 'scoder', 'vstinner', 'Arfrever', 'alex', 'petr.viktorin', 'python-dev', 'serhiy.storchaka', 'jdemeyer', 'xiang.zhang']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue22079'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']

[serhiy-storchaka]

It would be good if PyType_Ready() will check that base class of static type is static.

[pitrou]

By static, you mean not a heap type?

[alex]

Yup.

[serhiy-storchaka]

By static, you mean not a heap type?

Yes. Sorry for bad wording.

[serhiy-storchaka]

Here is a patch.

[serhiy-storchaka]

Could anyone please make a review?

[serhiy-storchaka]

Ping.

[python-dev]

New changeset c087ac6fc171 by Serhiy Storchaka in branch '2.7':
Issue bpo-22079: PyType_Ready() now checks that statically allocated type has
https://hg.python.org/cpython/rev/c087ac6fc171

New changeset 747855f29b9d by Serhiy Storchaka in branch '3.4':
Issue bpo-22079: PyType_Ready() now checks that statically allocated type has
https://hg.python.org/cpython/rev/747855f29b9d

New changeset eb26255e11f1 by Serhiy Storchaka in branch 'default':
Issue bpo-22079: PyType_Ready() now checks that statically allocated type has
https://hg.python.org/cpython/rev/eb26255e11f1

[doko42]

reopening, this breaks some stuff in several places ...

https://bugs.launchpad.net/ubuntu/+source/terminator/+bug/1426294

[serhiy-storchaka]

This restriction was added because bad thing could happen when statically allocated class inherits dynamically allocated class. I don't remember the number of the issue where such example was exposed, may be Alex remember it.

Likely pygobject creates classes in not safe manner. It would be more correct to create pygobject classes with PyType_FromSpec(), but current code worked for it for years. May be it is not so easy to change pygobject. So may be we should revert changes in 2.7 or convert the error to the deprecation warning.

Is there similar issue with 3.4? There may be difference due to the difference of the lifetime of types in 2.x and 3.x.