Improve imaplib testsuite.

[zvyn]

BPO	22111
Nosy	@pitrou, @bitdancer, @zvyn
Files	imaplib_test.patch imaplib_testV2.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-07-31.22:38:18.001>
created_at = <Date 2014-07-31.00:42:38.044>
labels = ['tests']
title = 'Improve imaplib testsuite.'
updated_at = <Date 2014-07-31.22:38:18.000>
user = 'https://github.com/zvyn'

bugs.python.org fields:

activity = <Date 2014-07-31.22:38:18.000>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2014-07-31.22:38:18.001>
closer = 'pitrou'
components = ['Tests']
creation = <Date 2014-07-31.00:42:38.044>
creator = 'zvyn'
dependencies = []
files = ['36171', '36178']
hgrepos = []
issue_num = 22111
keywords = ['patch']
message_count = 5.0
messages = ['224367', '224404', '224414', '224448', '224449']
nosy_count = 5.0
nosy_names = ['pitrou', 'r.david.murray', 'jesstess', 'python-dev', 'zvyn']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue22111'
versions = ['Python 3.5']

[zvyn]

The status quo of test_imaplib is a bit frustrating: 4 test functions out of 31 get executed by default while only few seem to need any resources.

I tried to solve this in the attached patch. Did I get something wrong or was that checking for network resources just a mistake?

[zvyn]

AntoinePitrou: Thanks for the review!
I made the suggested changes and could not resist refactoring the hole thing (since I plan to spend some time on that file I wanted it to be readable and pep conform).

[pitrou]

Thank you, Milan. The latest patch looks good to me.

[python-dev]

New changeset 6b2cafab7a9f by Antoine Pitrou in branch 'default':
Issue bpo-22111: Assorted cleanups in test_imaplib. Patch by Milan Oberkirch.
http://hg.python.org/cpython/rev/6b2cafab7a9f

[pitrou]

This is now pushed.