Return converter code generated by Argument Clinic has a warning for unsigned types

[vstinner]

BPO	22120
Nosy	@vstinner, @larryhastings, @serhiy-storchaka
Files	clinic.patch fix_warnings.patch larry.fix.unsigned.int.return.-1.converter.cast.1.txt

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/larryhastings'
closed_at = <Date 2014-08-05.09:57:13.800>
created_at = <Date 2014-08-02.00:14:08.539>
labels = ['type-bug', 'build']
title = 'Return converter code generated by Argument Clinic has a warning for unsigned types'
updated_at = <Date 2014-08-06.10:38:45.228>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2014-08-06.10:38:45.228>
actor = 'vstinner'
assignee = 'larry'
closed = True
closed_date = <Date 2014-08-05.09:57:13.800>
closer = 'larry'
components = ['Build']
creation = <Date 2014-08-02.00:14:08.539>
creator = 'vstinner'
dependencies = []
files = ['36201', '36205', '36266']
hgrepos = []
issue_num = 22120
keywords = ['patch']
message_count = 11.0
messages = ['224528', '224529', '224534', '224540', '224543', '224555', '224811', '224813', '224816', '224817', '224925']
nosy_count = 5.0
nosy_names = ['vstinner', 'larry', 'neologix', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue22120'
versions = ['Python 3.5']

[vstinner]

The issue bpo-22110 enabled more compiler warnings. Attached patch tries to fix most of them on Linux.

[vstinner]

clinic.patch: modify clinic.py to generate "return_value == (type)-1" instead of "return_value == -1" to avoid a warning if return_value is unsigned.

[serhiy-storchaka]

I think this should be done only for unsigned integer types. Otherwise it just dirty sources and can hide actual bugs.

[vstinner]

It would be better to only modify clinic for unsigned types, but how do you
check if a type is signed or not?

[serhiy-storchaka]

Either override render() for unsigned type converters, or add new converter
attribute (in additional to "type", "cast", "conversion_fn", etc).

[vstinner]

Hum, I forgot the attach the most important patch: fix_warnings.patch.

[larryhastings]

The title for this bug was almost offensively generic; it was hard to find in my email. If this new one is inaccurate, fix it--but please pick something more specific.

Attached is a patch for the "_return_value == -1" behavior for unsigned.

[serhiy-storchaka]

larry.fix.unsigned.int.return.-1.converter.cast.1.txt LGTM.

Victor, looks as you should open new issue for fix_warnings.patch. This is large patch and requires long time for careful review and may be discussion.

[python-dev]

New changeset 9c949e0115e2 by Larry Hastings in branch 'default':
Issue bpo-22120: For functions using an unsigned integer return converter,
http://hg.python.org/cpython/rev/9c949e0115e2

[larryhastings]

Fixed and closed. I'm assuming Victor will break the other patch out into its own issue.

Since IIUC there's no code in 3.4 that uses an unsigned integer return converter, I'm not backporting the fix.