Argument Clinic doesn't support the "type" argument for the int converter

[pitrou]

BPO	22615
Nosy	@brettcannon, @pitrou, @larryhastings
Files	larry.add.type.to.int.converter.1.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/larryhastings'
closed_at = <Date 2014-10-13.09:41:09.132>
created_at = <Date 2014-10-11.22:31:33.446>
labels = ['build']
title = 'Argument Clinic doesn\'t support the "type" argument for the int converter'
updated_at = <Date 2014-10-13.12:14:36.883>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2014-10-13.12:14:36.883>
actor = 'pitrou'
assignee = 'larry'
closed = True
closed_date = <Date 2014-10-13.09:41:09.132>
closer = 'larry'
components = ['Build']
creation = <Date 2014-10-11.22:31:33.446>
creator = 'pitrou'
dependencies = []
files = ['36884']
hgrepos = []
issue_num = 22615
keywords = ['patch']
message_count = 4.0
messages = ['229107', '229113', '229237', '229241']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'pitrou', 'larry', 'python-dev']
pr_nums = []
priority = 'critical'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue22615'
versions = ['Python 3.5']

[pitrou]

This is on the default branch.

$ make clinic
./python -E ./Tools/clinic/clinic.py --make
Error in file "./Modules/arraymodule.c" on line 1943:
Exception raised during parsing:
Traceback (most recent call last):
  File "./Tools/clinic/clinic.py", line 1626, in parse
    parser.parse(block)
  File "./Tools/clinic/clinic.py", line 3178, in parse
    self.state(line)
  File "./Tools/clinic/clinic.py", line 3660, in state_parameter
    converter = dict[name](c_name or parameter_name, parameter_name, self.function, value, **kwargs)
  File "./Tools/clinic/clinic.py", line 2200, in __init__
    self.converter_init(**kwargs)
TypeError: converter_init() got an unexpected keyword argument 'type'
make: *** [clinic] Erreur 255

[larryhastings]

Patch attached. Brett was using a feature that didn't exist, so I'm not sure how it could have worked for him. But it was a reasonable implicit feature request, and easy to implement, so here we are.

I'm not sure what's causing the churn in "bytesobject.c" here. It looks like someone changed the Clinic block in a way that it produces the same output, but didn't bother to run Clinic on it and check it in.

[python-dev]

New changeset c0224ff67cdd by Larry Hastings in branch 'default':
Issue bpo-22615: Argument Clinic now supports the "type" argument for the
https://hg.python.org/cpython/rev/c0224ff67cdd

[pitrou]

Thanks, Larry!