Remove some conditional code in _ssl.c

[pitrou]

BPO	23143
Nosy	@pitrou, @giampaolo, @tiran, @ned-deily, @alex, @dstufft

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-01-03.22:26:02.060>
created_at = <Date 2015-01-01.11:55:39.157>
labels = ['easy', 'type-feature', 'library']
title = 'Remove some conditional code in _ssl.c'
updated_at = <Date 2015-01-04.10:31:16.849>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2015-01-04.10:31:16.849>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2015-01-03.22:26:02.060>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2015-01-01.11:55:39.157>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 23143
keywords = ['easy']
message_count = 6.0
messages = ['233280', '233370', '233371', '233372', '233374', '233410']
nosy_count = 8.0
nosy_names = ['janssen', 'pitrou', 'giampaolo.rodola', 'christian.heimes', 'ned.deily', 'alex', 'python-dev', 'dstufft']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23143'
versions = ['Python 3.5']

[pitrou]

There's a lot of conditional code in _ssl.c, meant to address the unavailability of some features in old OpenSSL versions. I think for 3.5 we should require at least 0.9.8 (which is already old), and consequently remove some of those conditionals.

[dstufft]

+1, This sounds completely reasonable to do to me.

[python-dev]

New changeset e9f05a4a5f16 by Antoine Pitrou in branch 'default':
Issue bpo-23143: Remove compatibility with OpenSSLs older than 0.9.8.
https://hg.python.org/cpython/rev/e9f05a4a5f16

[python-dev]

New changeset 37c6fd09f71f by Antoine Pitrou in branch 'default':
Issue bpo-23143: Remove compatibility with OpenSSLs older than 0.9.8.
https://hg.python.org/cpython/rev/37c6fd09f71f

[pitrou]

Thanks! Now done.

[ned-deily]

Note that this change causes _ssl.so builds to fail on at least one buildbot, the OS X Tiger one, where the system OpenSSL version is 0.9.7. I've asked the buildbot owner to consider installing a local copy of a current OpenSSL. There may be other buildbots affected.