Add support of writing to unseekable file in zipfile

[serhiy-storchaka]

BPO	23252
Nosy	@bitdancer, @serhiy-storchaka
Files	zipfile_write_unseekable.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2015-03-23.08:35:07.357>
created_at = <Date 2015-01-16.19:55:48.019>
labels = ['type-feature', 'library']
title = 'Add support of writing to unseekable file in zipfile'
updated_at = <Date 2016-02-02.17:23:08.630>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2016-02-02.17:23:08.630>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2015-03-23.08:35:07.357>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2015-01-16.19:55:48.019>
creator = 'serhiy.storchaka'
dependencies = []
files = ['37970']
hgrepos = []
issue_num = 23252
keywords = ['patch']
message_count = 6.0
messages = ['234145', '235184', '236360', '238951', '259274', '259406']
nosy_count = 5.0
nosy_names = ['r.david.murray', 'python-dev', 'Matt.Mackall', 'serhiy.storchaka', 'Patrik Dufresne']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23252'
versions = ['Python 3.5']

[serhiy-storchaka]

ZIP files can be created to transfer it via unseekable streams (pipes, sockets). Mercurial uses a workaround to write ZIP files right to wsgirequest, but this is possible only with writestr(). write() needs seek() to updated file size, compressed sized and CRC. However ZIP file format supports streamed data without writing sizes and CRC before file data. It is possible and desirable to add full support of unseekable output files in zipfile.

[serhiy-storchaka]

Here is a patch. Mercurial wouldn't need a wrapper in Python 3.5.

[serhiy-storchaka]

Could you please make a review of the documentation part of the patch David?

[python-dev]

New changeset 19f36a2a34ec by Serhiy Storchaka in branch 'default':
Issue bpo-23252: Added support for writing ZIP files to unseekable streams.
https://hg.python.org/cpython/rev/19f36a2a34ec

[PatrikDufresne]

While this path provide support to create Zip file for non-seekable stream. It doesn't support reading a file from a non-seekable stream.

[serhiy-storchaka]

Currently the zipfile module requires seekable stream to read a list of entries from central directory at the end of ZIP file, and for reding their content in arbitrary order. The support of unseekable stream needs to design a new API. This is separate issue.