h2py.py regular expression missing

[ThomasRoos]

BPO	23330
Nosy	@loewis, @serhiy-storchaka
Files	IN.py.patch: patch to change regex in h2py.py

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2015-05-03.14:27:21.301>
created_at = <Date 2015-01-27.11:13:17.922>
labels = ['build']
title = 'h2py.py regular expression missing'
updated_at = <Date 2015-05-03.14:27:21.300>
user = 'https://bugs.python.org/ThomasRoos'

bugs.python.org fields:

activity = <Date 2015-05-03.14:27:21.300>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2015-05-03.14:27:21.301>
closer = 'serhiy.storchaka'
components = ['Cross-Build']
creation = <Date 2015-01-27.11:13:17.922>
creator = 'Thomas.Roos'
dependencies = []
files = ['37879']
hgrepos = []
issue_num = 23330
keywords = ['patch']
message_count = 4.0
messages = ['234817', '237031', '237040', '242472']
nosy_count = 4.0
nosy_names = ['loewis', 'python-dev', 'serhiy.storchaka', 'Thomas.Roos']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue23330'
versions = ['Python 2.7']

[ThomasRoos]

Hi,
my issue was that SO_BINDTODEVICE symbol was not defined in /Lib/plat-linux2/IN.py which is generated by h2py.py.
This is because the regex is missing out include dirs with "-" in the name.
In my yocto cross build system this define is in asm-generic, don't know about other build systems.
.../usr/include/asm-generic/socket.h:#define SO_BINDTODEVICE 25
so could you please change following regex in h2py.py (patch attached)
-p_include = re.compile('^[\t ]*#[\t ]include[\t ]+<([a-zA-Z0-9_/\.]+)')
+p_include = re.compile('^[\t ]#[\t ]*include[\t ]+<([a-zA-Z0-9_/\.-]+)')

[serhiy-storchaka]

my be change the pattern to '<([^\>\\n]+)>'?

[ThomasRoos]

works for me

[python-dev]

New changeset b32ca610c9e6 by Serhiy Storchaka in branch '2.7':
Issue bpo-23330: h2py now supports arbitrary filenames in #include.
https://hg.python.org/cpython/rev/b32ca610c9e6

New changeset 0079465a9425 by Serhiy Storchaka in branch '3.4':
Issue bpo-23330: h2py now supports arbitrary filenames in #include.
https://hg.python.org/cpython/rev/0079465a9425

New changeset f49e7e315d65 by Serhiy Storchaka in branch 'default':
Issue bpo-23330: h2py now supports arbitrary filenames in #include.
https://hg.python.org/cpython/rev/f49e7e315d65