PEP 441 - Improving Python Zip Application Support

[pfmoore]

BPO	23491
Nosy	@brettcannon, @pfmoore, @dholth, @ethanfurman, @berkerpeksag, @JimJJewett, @serhiy-storchaka, @zooba
Files	pep441.patch pep441.patch pep-441.patch pep-441.v4.patch pep-441.v5.patch pep-441.v6.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2015-03-13.14:45:26.083>
created_at = <Date 2015-02-20.12:52:51.249>
labels = ['type-feature', 'library']
title = 'PEP 441 - Improving Python Zip Application Support'
updated_at = <Date 2015-03-13.15:06:38.893>
user = 'https://github.com/pfmoore'

bugs.python.org fields:

activity = <Date 2015-03-13.15:06:38.893>
actor = 'paul.moore'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2015-03-13.14:45:26.083>
closer = 'brett.cannon'
components = ['Library (Lib)']
creation = <Date 2015-02-20.12:52:51.249>
creator = 'paul.moore'
dependencies = []
files = ['38187', '38192', '38250', '38258', '38389', '38419']
hgrepos = []
issue_num = 23491
keywords = ['patch']
message_count = 42.0
messages = ['236276', '236285', '236286', '236291', '236301', '236308', '236455', '236457', '236458', '236459', '236531', '236534', '236669', '236670', '236672', '236673', '236675', '236676', '236678', '236680', '236682', '236688', '236689', '236694', '236698', '236700', '236704', '236705', '236707', '236736', '236740', '236745', '237304', '237539', '237544', '237740', '237741', '237764', '237766', '238028', '238029', '238032']
nosy_count = 9.0
nosy_names = ['brett.cannon', 'paul.moore', 'dholth', 'ethan.furman', 'python-dev', 'berker.peksag', 'Jim.Jewett', 'serhiy.storchaka', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23491'
versions = ['Python 3.5']

[pfmoore]

This is the patch for PEP-441 (Zip Application Support).

Steve, could you check the installer changes, please? I haven't managed to get a setup where I can test the installer, and I'm not aware of any WiX coding tools, so I just edited the XML files by hand with grep and vim, and checked that Tools/buildmsi.bat doesn't error in anything I wrote... (There's a CRC check error in TCL, but that was there before I made changes)

light.exe : error LGHT0216: An unexpected Win32 exception with error code 0x17 occurred while accessing file 'C:\Work\Projects\cpython\externals\tcltk64\lib\tcl8.6\tzdata\America\Detroit': Data error (cyclic redundancy check) [C:\Work\Projects\cpython\Tools\msi\tcltk\tcltk.wixproj]

Also, I don't *think* I need to do anything for the new files in Doc\Lib, Lib and Lib\test to get picked up, but I'm not sure how to check that.

[zooba]

The installer changes look fine, though there shouldn't be PATH related strings in exe/, so there's probably a separate issue there. Wix doesn't really have any editors that aren't just XML editors.

We probably want to update the ContentType value from text/plain for all the shortcuts, though I'm not sure what to (it affects the implicit associations and extra commands on the files, inc. Open With).

The easiest way to make sure the files are in the installer is to install it :) But if they're just .py files under Lib/ then they'll be there.

[zooba]

I haven't looked closely at the rest, btw. Will try and find time today or tomorrow.

[pfmoore]

Thanks for checking, Steve. I don't get an installer because of the checksum error quoted, although I did get the component msi files.

As far as content type is concerned, I wasn't sure what effect it had so I just copied what was there. I guess application/zip might be better for .pyz files, based on what you said?

I'm not sure what you meant by the comment about exe/. All I did was mention .pyz as well as .py - although I don't see where the PathDescription string us used so I may be missing something important!

[zooba]

Either "application/zip" or "application/x-zip-compressed", I'm not sure exactly what the difference is, but the default .zip association has the latter.

The CRC error may be your machine or it may be because we're currently running on unstable WiX releases (hey, everything else is unstable right now :) ). If you can edit and re-save that file, I'd expect it to work, otherwise the 32-bit installer should be okay.

The exe/ comment is more a note for myself, sorry. Those strings are unused and should be removed (I'll do that now - got a few things to fix).

[pfmoore]

Thanks. Updated patch with the new mime-type.

Looks like there's disk errors on that file with the CRC check. Lovely :-)

[dholth]

It looks like your patch does not register PYZW in Windows

[zooba]

It registers the association, but doesn't add it to PATHEXT.

[dholth]

I don't see the string PYZW anywhere in the patch, I only see PYZ,
perhaps I don't know enough about this bug tracker or registering file
extensions?

On Mon, Feb 23, 2015, at 01:19 PM, Steve Dower wrote:

Steve Dower added the comment:

It registers the association, but doesn't add it to PATHEXT.

----------

---

Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue23491\>

---

[zooba]

It's this line:

<Extension Id="$(var.ArchiveFileExtension)w" ContentType="application/x-zip-compressed">

$(var.ArchiveFileExtension) expands to "pyz" or "pxz" depending on the build options, and the literal w makes it pyzw or pxzw.

[dholth]

Spelling

raise PackError("Cannot spacify entry point if the source has __main__.py")

[pfmoore]

Thanks, I'll fix for the next iteration of the patch.