unittest.mock.MagicMock doesn't support __rdivmod__

[zkrynicki]

BPO	23568
Nosy	@rbtcollins, @voidspace, @berkerpeksag
Files	issue23568.patch: patch and test

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-03-15.00:02:16.017>
created_at = <Date 2015-03-03.08:36:25.964>
labels = ['type-bug', 'library']
title = "unittest.mock.MagicMock doesn't support __rdivmod__"
updated_at = <Date 2015-03-15.00:02:16.014>
user = 'https://bugs.python.org/zkrynicki'

bugs.python.org fields:

activity = <Date 2015-03-15.00:02:16.014>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2015-03-15.00:02:16.017>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2015-03-03.08:36:25.964>
creator = 'zkrynicki'
dependencies = []
files = ['38373']
hgrepos = []
issue_num = 23568
keywords = ['patch']
message_count = 4.0
messages = ['237112', '237441', '238111', '238112']
nosy_count = 6.0
nosy_names = ['rbcollins', 'michael.foord', 'python-dev', 'berker.peksag', 'zkrynicki', 'H\xc3\xa5kan L\xc3\xb6vdahl']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue23568'
versions = ['Python 3.4', 'Python 3.5']

[zkrynicki]

Hey.

I'm the upstream developer of padme https://github.com/zyga/padme -- the mostly transparent proxy class for Python. While working on unit tests for proxying numeric methods I realized that there are a few bugs in the mock library.

The bug I'd like to report now is that __rdivmod__ cannot be mocked by MagicMock. This seems to be caused by the fact that it is listed as magic but not as numeric (for which right-hand-side variants are created).

Note that it cannot be simply added to numeric as it doesn't have the augmented assignment variant (there is no __idivmod__).

The bug is present in all versions of Python that come with unittest.mock (3.3, 3.4 and 3.5) and it is also present in the upstream/standalone version of mock

[HkanLvdahl]

I wrote a small patch and a test for it. Tested it on Python 3.5 and it worked.

[python-dev]

New changeset 35a780a9a3b4 by Berker Peksag in branch '3.4':
Issue bpo-23568: Add rdivmod support to MagicMock() objects.
https://hg.python.org/cpython/rev/35a780a9a3b4

New changeset 90f08e7fbdc3 by Berker Peksag in branch 'default':
Issue bpo-23568: Add rdivmod support to MagicMock() objects.
https://hg.python.org/cpython/rev/90f08e7fbdc3

[berkerpeksag]

Thanks to both of you for the report and the patch.