urljoin() with no directory segments duplicates filename

[vadmium]

BPO	23703
Nosy	@orsenthil, @berkerpeksag, @vadmium, @demianbrecht
Files	issue23703.patch issue23703_1.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-04-15.23:34:22.985>
created_at = <Date 2015-03-19.07:09:16.092>
labels = ['type-bug', 'library']
title = 'urljoin() with no directory segments duplicates filename'
updated_at = <Date 2015-04-15.23:34:22.984>
user = 'https://github.com/vadmium'

bugs.python.org fields:

activity = <Date 2015-04-15.23:34:22.984>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2015-04-15.23:34:22.985>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2015-03-19.07:09:16.092>
creator = 'martin.panter'
dependencies = []
files = ['38563', '38573']
hgrepos = []
issue_num = 23703
keywords = ['patch']
message_count = 7.0
messages = ['238493', '238531', '238566', '238590', '241082', '241177', '241178']
nosy_count = 5.0
nosy_names = ['orsenthil', 'python-dev', 'berker.peksag', 'martin.panter', 'demian.brecht']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue23703'
versions = ['Python 3.5']

[vadmium]

This is a regression caused by revision 901e4e52b20a. Before (e.g. Python 3.4):

>>> urljoin('a', 'b')
'b'

After:

>>> urljoin('a', 'b')
'b/b'

This was identified in <https://bugs.python.org/issue18828#msg238363\> but is actually caused by the revision committed for bpo-22278.

[demianbrecht]

Nice work tracking down the commit, thanks for that. I've attached a fix.

[vadmium]

Patch looks good enough.

BTW I was thinking of something like this, which is a bit simpler, but I never tested it:

segments[1:-1] = filter(None, segments[1:-1])

[demianbrecht]

Yep, that's a lot cleaner and tests pass. I've updated the patch with that line. Thanks.

[vadmium]

Any chance this regression can be fixed before the next release?

[python-dev]

New changeset fc0e79387a3a by Berker Peksag in branch 'default':
Issue bpo-23703: Fix a regression in urljoin() introduced in 901e4e52b20a.
https://hg.python.org/cpython/rev/fc0e79387a3a

[berkerpeksag]

Thanks!