Enhancing IDLE's test_delegator.py unit test

[AlSweigart]

BPO	23977
Nosy	@terryjreedy
Files	test_delegator.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2016-05-16.02:08:11.142>
created_at = <Date 2015-04-16.22:18:37.315>
labels = ['type-feature', 'tests']
title = "Enhancing IDLE's test_delegator.py unit test"
updated_at = <Date 2016-05-16.02:08:11.141>
user = 'https://bugs.python.org/AlSweigart'

bugs.python.org fields:

activity = <Date 2016-05-16.02:08:11.141>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2016-05-16.02:08:11.142>
closer = 'terry.reedy'
components = ['Tests']
creation = <Date 2015-04-16.22:18:37.315>
creator = 'Al.Sweigart'
dependencies = []
files = ['39078']
hgrepos = []
issue_num = 23977
keywords = ['patch']
message_count = 3.0
messages = ['241284', '265584', '265659']
nosy_count = 3.0
nosy_names = ['terry.reedy', 'python-dev', 'Al.Sweigart']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23977'
versions = ['Python 3.5', 'Python 3.6']

[AlSweigart]

As part of trying to understand the IDLE codebase, I'm taking a look at IDLE's unit tests.

-Added more specific messages when test_delegator.py's assertions fail.
-Added detail to the comments.
-Added an explicit test of the resetcache() method (which before was only tested as far as it was called when setdelegate() was called).

I've rerun the unit test on the existing source code and it passes.

[terryjreedy]

The patch adds too much. Some of the comments are too obvious. See PEP-8. Many of the messages repeat the information already provided in the custom messages already provided by the assertXyz failure methods. For instance, when assertEqual(a, b) fails, the message already prints out something like "%s != $s" % (repr(a), repr(b)). Perhaps you were not familiar with this. One of the problems of retrofitting tests is that we do not see the default failure messages.

In any case, over-commenting and over-messaging are not harmless as they make code and failure messages harder, not easier to read. I will review and add what I think is useful.

[python-dev]

New changeset 6bc08af57813 by Terry Jan Reedy in branch '3.5':
Issue bpo-23977: Tweak IDLE Delegator and its test.
https://hg.python.org/cpython/rev/6bc08af57813