PyImport_ReInitLock() doesn't check for allocation error

[tiran]

BPO	23998
Nosy	@brettcannon, @tiran
Files	import_reinit_fatal.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tiran'
closed_at = <Date 2015-04-20.14:52:14.763>
created_at = <Date 2015-04-18.22:42:35.033>
labels = ['easy', 'type-bug']
title = "PyImport_ReInitLock() doesn't check for allocation error"
updated_at = <Date 2015-04-20.14:52:14.762>
user = 'https://github.com/tiran'

bugs.python.org fields:

activity = <Date 2015-04-20.14:52:14.762>
actor = 'christian.heimes'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2015-04-20.14:52:14.763>
closer = 'christian.heimes'
components = []
creation = <Date 2015-04-18.22:42:35.033>
creator = 'christian.heimes'
dependencies = []
files = ['39110']
hgrepos = []
issue_num = 23998
keywords = ['patch', 'easy', 'buildbot']
message_count = 4.0
messages = ['241462', '241517', '241547', '241656']
nosy_count = 3.0
nosy_names = ['brett.cannon', 'christian.heimes', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue23998'
versions = ['Python 2.7', 'Python 3.3', 'Python 3.4', 'Python 3.5']

[tiran]

_PyImport_ReInitLock() doesn't check the return value of PyThread_allocate_lock(). A failed lock allocation can either lead to a NULL pointer dereference or to race conditions caused by a missing import lock.

As there is no way to recover from a failed lock allication I recommend to abort with a fatal error.

CID 1295025 (#1 of 1): Dereference after null check (FORWARD_NULL)
var_deref_model: Passing null pointer import_lock to PyThread_acquire_lock, which dereferences it.

[brettcannon]

LGTM

[python-dev]

New changeset d70995cf44b3 by Christian Heimes in branch '2.7':
Issue bpo-23998: PyImport_ReInitLock() now checks for lock allocation error
https://hg.python.org/cpython/rev/d70995cf44b3

New changeset 7d7bf5c34d7e by Christian Heimes in branch '3.3':
Issue bpo-23998: PyImport_ReInitLock() now checks for lock allocation error
https://hg.python.org/cpython/rev/7d7bf5c34d7e

New changeset e0bd083fc9c1 by Christian Heimes in branch '3.4':
Issue bpo-23998: PyImport_ReInitLock() now checks for lock allocation error
https://hg.python.org/cpython/rev/e0bd083fc9c1

New changeset 7ae8fd62d743 by Christian Heimes in branch 'default':
Issue bpo-23998: PyImport_ReInitLock() now checks for lock allocation error
https://hg.python.org/cpython/rev/7ae8fd62d743

[tiran]

Thanks, Brett!