ctypes.utils uninitialized variable 'paths'

[kees]

BPO	24114
Nosy	@amauryfa, @abalkin, @meadori, @vadmium, @zhangyangyu
Files	ctypes.util-path.patch: patch for uninitialized variable 'path' issue24114.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/meadori'
closed_at = <Date 2016-05-01.03:32:51.262>
created_at = <Date 2015-05-02.15:03:15.182>
labels = ['easy', 'ctypes', 'type-bug']
title = "ctypes.utils uninitialized variable 'paths'"
updated_at = <Date 2016-05-01.03:32:51.260>
user = 'https://bugs.python.org/kees'

bugs.python.org fields:

activity = <Date 2016-05-01.03:32:51.260>
actor = 'meador.inge'
assignee = 'meador.inge'
closed = True
closed_date = <Date 2016-05-01.03:32:51.262>
closer = 'meador.inge'
components = ['ctypes']
creation = <Date 2015-05-02.15:03:15.182>
creator = 'kees'
dependencies = []
files = ['39267', '42637']
hgrepos = []
issue_num = 24114
keywords = ['patch', 'easy']
message_count = 8.0
messages = ['242401', '243288', '243299', '264425', '264426', '264428', '264577', '264578']
nosy_count = 7.0
nosy_names = ['amaury.forgeotdarc', 'belopolsky', 'kees', 'meador.inge', 'python-dev', 'martin.panter', 'xiang.zhang']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue24114'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']

[kees]

In certain corner cases, the ctypes.util can raise an error for a uninitialized variable 'path' when with sunos5 the clre program exists, but fails to return valid output lines.

(Also in 2.7.10rc0)

[vadmium]

I fail to see how this patch does anything. What is the actual error or traceback? Perhaps it is for “paths” (plural)?

[kees]

Sorry, yes. It's plural: 'paths'

[zhangyangyu]

Simply add one line to make the function theoretically more robust.

[kees]

It's not entirely theoretical to me. I inherited some solaris boxes that cannot be properly maintained anymore and that have a clre program that dumps core. Hence no valid output and running into uninitialized 'paths'. The patch from Xiang Zhang will fix that.

[meadori]

Xiang's patch LGTM. Given that Kees has verified it, I will apply today.

[python-dev]

New changeset 57bf7a40925f by Meador Inge in branch '2.7':
Issue bpo-24114: Fix an uninitialized variable in ctypes.util.
https://hg.python.org/cpython/rev/57bf7a40925f

New changeset db5baad7ad69 by Meador Inge in branch '3.5':
Issue bpo-24114: Fix an uninitialized variable in ctypes.util.
https://hg.python.org/cpython/rev/db5baad7ad69

New changeset 5b5fbce1db9c by Meador Inge in branch 'default':
Issue bpo-24114: Fix an uninitialized variable in ctypes.util.
https://hg.python.org/cpython/rev/5b5fbce1db9c

[meadori]

Fixed.

Thank y'all for the patch and help with testing.