Unhandled error results of C API functions

[serhiy-storchaka]

BPO	24115
Nosy	@serhiy-storchaka
Files	issue24115.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2015-05-30.14:50:12.164>
created_at = <Date 2015-05-02.16:56:26.514>
labels = ['extension-modules', 'interpreter-core', 'type-bug']
title = 'Unhandled error results of C API functions'
updated_at = <Date 2015-05-30.14:50:12.163>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2015-05-30.14:50:12.163>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2015-05-30.14:50:12.164>
closer = 'serhiy.storchaka'
components = ['Extension Modules', 'Interpreter Core']
creation = <Date 2015-05-02.16:56:26.514>
creator = 'serhiy.storchaka'
dependencies = []
files = ['39451']
hgrepos = []
issue_num = 24115
keywords = ['patch']
message_count = 3.0
messages = ['242407', '243741', '244460']
nosy_count = 3.0
nosy_names = ['Arfrever', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue24115'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5', 'Python 3.6']

[serhiy-storchaka]

PyObject_IsInstance() and PyObject_IsSubclass() cat return 0, 1, or -1. But some code use "if (PyObject_IsInstance(...))" or "if (!PyObject_IsInstance(...))". This should be fixed.

[serhiy-storchaka]

Proposed patch adds handling of error results of following functions: PyObject_IsTrue(), PyObject_Not(), PyObject_IsInstance(), PyObject_RichCompareBool(), _PyDict_Contains(). All these functions usually return 0 or 1, but also can return -1 in the case of error, and this case was not handled in some places.

[python-dev]

New changeset 82490d05f3b0 by Serhiy Storchaka in branch '2.7':
Issue bpo-24115: Update uses of PyObject_IsTrue(), PyObject_Not(),
https://hg.python.org/cpython/rev/82490d05f3b0

New changeset 8167df7d4cd0 by Serhiy Storchaka in branch '3.4':
Issue bpo-24115: Update uses of PyObject_IsTrue(), PyObject_Not(),
https://hg.python.org/cpython/rev/8167df7d4cd0

New changeset 7d1b81224c3b by Serhiy Storchaka in branch '3.5':
Issue bpo-24115: Update uses of PyObject_IsTrue(), PyObject_Not(),
https://hg.python.org/cpython/rev/7d1b81224c3b

New changeset f5d1bb0c4192 by Serhiy Storchaka in branch 'default':
Issue bpo-24115: Update uses of PyObject_IsTrue(), PyObject_Not(),
https://hg.python.org/cpython/rev/f5d1bb0c4192