Idle: remove idlelib.idlever.py and its use in About dialog

[terryjreedy]

BPO	24199
Nosy	@brettcannon, @terryjreedy, @larryhastings, @benjaminp, @serhiy-storchaka

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2015-09-20.06:36:04.310>
created_at = <Date 2015-05-15.00:38:05.387>
labels = ['expert-IDLE', 'type-feature']
title = 'Idle: remove idlelib.idlever.py and its use in About dialog'
updated_at = <Date 2015-09-20.06:36:04.309>
user = 'https://github.com/terryjreedy'

bugs.python.org fields:

activity = <Date 2015-09-20.06:36:04.309>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2015-09-20.06:36:04.310>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2015-05-15.00:38:05.387>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 24199
keywords = []
message_count = 14.0
messages = ['243237', '243246', '243263', '243380', '243381', '243620', '243862', '250248', '250250', '250288', '250290', '250975', '251047', '251151']
nosy_count = 7.0
nosy_names = ['brett.cannon', 'terry.reedy', 'larry', 'benjamin.peterson', 'Arfrever', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue24199'
versions = ['Python 3.6']

[terryjreedy]

Once upon a time, Idle was versioned separately from Python, though updated in lockstep with Python (bpo-1515164, Martin's comment). The version was kept in idlever.py, with one line
IDLE_VERSION = "m.n.p"

Several years ago, the separate versioning was dropped (or decreed to be the same as the Python version -- no issue for this). idlever.py was kept and made to contain the initial part of sys.version (sys.version.split()[0]). It gets patched as part of the version bump process, Most recently 80ccce248ba2 (Benjamin) and 413e0e0004f4 (Larry). Is that part of an automated script?

The only current use of idlever is for the About Idle box (aboutDialog.py), which prints two lines with redundant information:
'Python version: ' + sys.version.split()[0]
'IDLE version: ' + idlever.IDLE_VERSION

idlever.py is not needed and I intend to remove it. But before or as I do, its patching needs to be removed from the version bump process.

I would also like to remove "IDLE version ..." from the dialog box, but even if not, idlever.py is not needed.

[benjaminp]

That's fine. Just delete idlever.py, and I'll deal with it.

[serhiy-storchaka]

Are there third-party IDLE plugins? If yes, this change can break them.

[python-dev]

New changeset c473ac171041 by Terry Jan Reedy in branch '2.7':
Issue bpo-24199: Stop using idelver in aboutdialog.
https://hg.python.org/cpython/rev/c473ac171041

New changeset c862166060ed by Terry Jan Reedy in branch '3.4':
Issue bpo-24199: Make idlever module self updating. Syop using it in aboutDialog.
https://hg.python.org/cpython/rev/c862166060ed

[terryjreedy]

Benjamim, I made idlever update from sys.version until removed, so remove it from release process.

Serhiy, yes there are extensions which might possibly use this private api, even if they really should not. I want to bring Nick (PEP-434 approver) into the discussion of the timing of removal.

Is there any problem with respect to buildbots of raising a DeprecationWarning when a module is imported? Is so, can a module be excluded from the import all test?

[terryjreedy]

To answer my question, I checked test___all__.py. The check_all helper has this:
with support.check_warnings(
(".* (module|package)", DeprecationWarning),
("", ResourceWarning),
quiet=True):
I presume this means that DeprecationWarnings raised by the following import are suppressed. (There is also a blacklist.)

[python-dev]

New changeset 117af4bc0513 by Benjamin Peterson in branch '2.7':
make idlever.py self-updating (closes bpo-24199)
https://hg.python.org/cpython/rev/117af4bc0513

[terryjreedy]

Re-opening because there is still the issue of adding a deprecation warning on import. Brett, can you either point me toward or post here the code you are planning to use for other stdlib modules?

[brettcannon]

Typically it's warnings.warn(message, DeprecationWarning, stacklevel=2), but that stack level is wrong for Python 3.3 - 3.4 (fixed in 3.5.0). If this is purely for Python 3.6 I might be adding a nicer API for module deprecations, but if this is for other versions then the call above is the right one except for Python 3.3/3.4.

[python-dev]

New changeset 55b62e2c59f8 by Terry Jan Reedy in branch '2.7':
bpo-24199: Deprecate idlelib.idlever with a warning on import.
https://hg.python.org/cpython/rev/55b62e2c59f8

New changeset c51514826126 by Terry Jan Reedy in branch '3.4':
bpo-24199: Deprecate idlelib.idlever with a warning on import.
https://hg.python.org/cpython/rev/c51514826126