regression for importing extensions in packages

[ronaldoussoren]

BPO	24285
Nosy	@brettcannon, @ronaldoussoren, @ncoghlan, @encukou, @ericsnowcurrently
Superseder	bpo-24268: PEP 489 -- Multi-phase extension module initialization
Files	issue-24285.txt

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-05-25.21:22:20.206>
created_at = <Date 2015-05-25.12:04:49.785>
labels = ['type-bug']
title = 'regression for importing extensions in packages'
updated_at = <Date 2015-05-26.11:58:35.750>
user = 'https://github.com/ronaldoussoren'

bugs.python.org fields:

activity = <Date 2015-05-26.11:58:35.750>
actor = 'ncoghlan'
assignee = 'none'
closed = True
closed_date = <Date 2015-05-25.21:22:20.206>
closer = 'berker.peksag'
components = []
creation = <Date 2015-05-25.12:04:49.785>
creator = 'ronaldoussoren'
dependencies = []
files = ['39494']
hgrepos = []
issue_num = 24285
keywords = []
message_count = 5.0
messages = ['244030', '244031', '244035', '244098', '244099']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'ronaldoussoren', 'ncoghlan', 'petr.viktorin', 'python-dev', 'eric.snow']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = '24268'
type = 'behavior'
url = 'https://bugs.python.org/issue24285'
versions = ['Python 3.5']

[ronaldoussoren]

PyObjC has an extension that's imported as "objc._objc". This works fine on version upto the 3.5 beta (checkout from earlier today).

With that I get the following exception:

Python 3.5.0b1+ (default:7255af1a1c50+, May 25 2015, 11:46:18) 
[GCC 4.2.1 Compatible Apple LLVM 6.1.0 (clang-602.0.53)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import objc
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/ronald/Projects/pyobjc-hg/pyobjc/pyobjc-core/Lib/objc/__init__.py", line 18, in <module>
    _update()
  File "/Users/ronald/Projects/pyobjc-hg/pyobjc/pyobjc-core/Lib/objc/__init__.py", line 15, in _update
    import objc._objc as _objc
ImportError: dynamic module does not define module export function (PyInit_._objc)

[ronaldoussoren]

The attached patch appears to fix the issue. This appears to be an off-by-one error.

[encukou]

bpo-24268 has a patch with a test case.

[python-dev]

New changeset 55e6f3f94b99 by Nick Coghlan in branch '3.5':
Issue bpo-24285: fix importing extensions from packages
https://hg.python.org/cpython/rev/55e6f3f94b99

New changeset 32ee7b9d58c9 by Nick Coghlan in branch 'default':
Merge fix for issue bpo-24285 from 3.5
https://hg.python.org/cpython/rev/32ee7b9d58c9

[ncoghlan]

Since this error was in the beta release, I used this issue reference in the NEWS file, rather than the original implementation issue.