incorrect decref in C OrderedDict

[ericsnowcurrently]

BPO	24348
Nosy	@skrah, @ericsnowcurrently, @1st1
Files	crash-2.py

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ericsnowcurrently'
closed_at = <Date 2015-06-02.05:15:22.281>
created_at = <Date 2015-06-01.16:21:56.379>
labels = ['library', 'type-crash', 'release-blocker']
title = 'incorrect decref in C OrderedDict'
updated_at = <Date 2015-06-02.05:15:22.280>
user = 'https://github.com/ericsnowcurrently'

bugs.python.org fields:

activity = <Date 2015-06-02.05:15:22.280>
actor = 'eric.snow'
assignee = 'eric.snow'
closed = True
closed_date = <Date 2015-06-02.05:15:22.281>
closer = 'eric.snow'
components = ['Library (Lib)']
creation = <Date 2015-06-01.16:21:56.379>
creator = 'eric.snow'
dependencies = []
files = ['39589']
hgrepos = []
issue_num = 24348
keywords = []
message_count = 2.0
messages = ['244598', '244650']
nosy_count = 5.0
nosy_names = ['Arfrever', 'skrah', 'python-dev', 'eric.snow', 'yselivanov']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue24348'
versions = ['Python 3.5', 'Python 3.6']

[ericsnowcurrently]

(from msg244575 in bpo-16991)

crash-2.py is due to the fact that _PyDict_Pop() deletes a reference
to 'key' in _odict_popkey().

The INCREF(key) in popitem should take place before calling _odict_popkey().

Again, I don't see the point of INCREF/DECREF *inside* of _odict_popkey().

[python-dev]

New changeset 8631b88c23f6 by Eric Snow in branch '3.5':
Issue bpo-24348: Drop superfluous increfs/decrefs.
https://hg.python.org/cpython/rev/8631b88c23f6