inconsistency in http.server.test

[wdv4758h]

BPO	24774
Nosy	@rbtcollins, @vadmium
Files	fix_description.patch: fix description

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-08-17.00:21:01.670>
created_at = <Date 2015-08-01.19:19:49.567>
labels = ['type-bug', 'library']
title = 'inconsistency in http.server.test'
updated_at = <Date 2015-08-17.00:21:01.647>
user = 'https://bugs.python.org/wdv4758h'

bugs.python.org fields:

activity = <Date 2015-08-17.00:21:01.647>
actor = 'rbcollins'
assignee = 'none'
closed = True
closed_date = <Date 2015-08-17.00:21:01.670>
closer = 'rbcollins'
components = ['Library (Lib)']
creation = <Date 2015-08-01.19:19:49.567>
creator = 'wdv4758h'
dependencies = []
files = ['40095']
hgrepos = []
issue_num = 24774
keywords = ['patch']
message_count = 6.0
messages = ['247821', '247834', '247870', '248240', '248696', '248697']
nosy_count = 4.0
nosy_names = ['rbcollins', 'python-dev', 'martin.panter', 'wdv4758h']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue24774'
versions = ['Python 3.4', 'Python 3.5', 'Python 3.6']

[wdv4758h]

In http.server.test, it still say "This runs an HTTP server on port 8000 (or the first command line argument).", but it won't read command line argument any more.

since this commit (https://hg.python.org/cpython/rev/935a656359ae)

[vadmium]

Patch looks okay to me, although another option could be to move the argument parsing back into the test() function, where it was originally.

BTW I don’t think the 3.3 branch is open to fixes like this any more.

[wdv4758h]

I'm not quite sure we should put argument parsing back into the test() function or just fix docstring. It already expose port and bind through function arguments. It looks wierd to me to have function arguments & CLI arguments modifying the same variable in the same time. If we want to move argument parsing back, I think we should clean the function parameters. In this way, the docstring of test function still need some update, though. (we have much more CLI arguments now)

[vadmium]

Yeah you are probably right. This way keeps things simple.

[python-dev]

New changeset d9e0c82d8653 by Robert Collins in branch '3.4':
Issue bpo-24774: Fix docstring in http.server.test.
https://hg.python.org/cpython/rev/d9e0c82d8653

New changeset 845c79097c21 by Robert Collins in branch '3.5':
Issue bpo-24774: Fix docstring in http.server.test.
https://hg.python.org/cpython/rev/845c79097c21

New changeset a8de693ebe66 by Robert Collins in branch 'default':
Issue bpo-24774: Fix docstring in http.server.test.
https://hg.python.org/cpython/rev/a8de693ebe66

[rbtcollins]

Thanks for the patch. Applied to 3.4 and up.