platform._syscmd_ver raises DeprecationWarning

[zooba]

BPO	24839
Nosy	@malemburg, @larryhastings, @zooba
Files	platform_popen.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-08-11.04:11:22.497>
created_at = <Date 2015-08-10.18:15:43.906>
labels = ['type-bug']
title = 'platform._syscmd_ver raises DeprecationWarning'
updated_at = <Date 2015-08-11.11:04:17.028>
user = 'https://github.com/zooba'

bugs.python.org fields:

activity = <Date 2015-08-11.11:04:17.028>
actor = 'larry'
assignee = 'none'
closed = True
closed_date = <Date 2015-08-11.04:11:22.497>
closer = 'steve.dower'
components = []
creation = <Date 2015-08-10.18:15:43.906>
creator = 'steve.dower'
dependencies = []
files = ['40158']
hgrepos = []
issue_num = 24839
keywords = ['patch']
message_count = 9.0
messages = ['248364', '248367', '248372', '248376', '248383', '248387', '248388', '248401', '248402']
nosy_count = 4.0
nosy_names = ['lemburg', 'larry', 'python-dev', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue24839'
versions = ['Python 3.5', 'Python 3.6']

[zooba]

platform._syscmd_ver() calls platform.popen() which raises a DeprecationWarning. This causes tests with @skip(platform.machine() == '...') decorators to fail.

The fix is to call os.popen() - patch attached. (platform.popen() just raises the warning and then calls os.popen(), so should be no risk here.)

Larry - since this causes spurious failures in numpy's test suite, can we get it into 3.5?

[larryhastings]

Yes, I'll accept that for 3.5.0. Paste a link to a pull request here at your earliest convenience (and opportunity).

[zooba]

Have you opened up the repo yet? I'm getting "no access" errors from BB.

[larryhastings]

Not yet. I'll open it after I release 3.5.0rc1. I'll send email to clp-d and clp-c when I do. I can email you privately too if you like.

[larryhastings]

My Bitbucket repo is now public.

https://bitbucket.org/larry/cpython350

[python-dev]

New changeset 7cfe20a6395d by Steve Dower in branch '3.5':
Issue bpo-24839: platform._syscmd_ver raises DeprecationWarning
https://hg.python.org/cpython/rev/7cfe20a6395d

[zooba]

PR is at https://bitbucket.org/larry/cpython350/pull-requests/1/issue-24839-platform_syscmd_ver-raises/diff

(For my sanity, your 3.5 branch and the hg.p.o 3.5 branch *are* currently in sync, yes? Any value in adding a 3.5.0 branch for your divergence so we can avoid the need for multiple clones?)

[larryhastings]

They are currently in sync, yes. The 3.5 branch has been a ghost town the last day or two, which tbh has been pleasant for me.helpfu

[larryhastings]

Merged. Please forward-port to 3.5.1 and 3.6. Thanks!

(See? Already I can tell this rc-cycle is going to be way easier on me than 3.4 was.)