Asyncio Task.get_stack fails with native coroutines

[habilain]

BPO	24867
Nosy	@gvanrossum, @vstinner, @larryhastings, @1st1
Files	fix_asyncio_task_get_frame.diff: Patch to fix issue

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/1st1'
closed_at = <Date 2015-08-14.19:37:17.951>
created_at = <Date 2015-08-14.15:26:22.263>
labels = ['release-blocker', 'expert-asyncio']
title = 'Asyncio Task.get_stack fails with native coroutines'
updated_at = <Date 2015-08-25.21:35:24.234>
user = 'https://bugs.python.org/habilain'

bugs.python.org fields:

activity = <Date 2015-08-25.21:35:24.234>
actor = 'python-dev'
assignee = 'yselivanov'
closed = True
closed_date = <Date 2015-08-14.19:37:17.951>
closer = 'yselivanov'
components = ['asyncio']
creation = <Date 2015-08-14.15:26:22.263>
creator = 'habilain'
dependencies = []
files = ['40179']
hgrepos = []
issue_num = 24867
keywords = ['patch']
message_count = 6.0
messages = ['248589', '248590', '248607', '248608', '249083', '249161']
nosy_count = 6.0
nosy_names = ['gvanrossum', 'vstinner', 'larry', 'python-dev', 'yselivanov', 'habilain']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue24867'
versions = ['Python 3.5']

[habilain]

I've been playing around with native coroutines and asyncio, and came across an issue with retrieving exceptions from tasks: The get_frame method on a Task in asyncio fails with an AttibuteError because it assumes that gi_frame as the attribute containing the stack frame; with native coroutines it's cr_frame.

I've attached a quick patch that just uses hasattr to see if gi_frame is present, and if not try cr_frame. This may not be the most elegant solution, but it does fix the issue. If there's any other stuff I can provide to help with this (within reason), just say the word.

[habilain]

It should be noted that when I said get_frame in the original comment, I actually meant get_stack

[python-dev]

New changeset 53d2a7c023bc by Yury Selivanov in branch '3.4':
Issue bpo-24867: Fix Task.get_stack() for 'async def' coroutines
https://hg.python.org/cpython/rev/53d2a7c023bc

New changeset d25022765186 by Yury Selivanov in branch '3.5':
Merge 3.4 (Issue bpo-24867)
https://hg.python.org/cpython/rev/d25022765186

New changeset c0b7829e3074 by Yury Selivanov in branch 'default':
Merge 3.5 (issue bpo-24867)
https://hg.python.org/cpython/rev/c0b7829e3074

[1st1]

Looks like we didn't have unittests for Task.get_stack()/Task.print_stack().

Anyways, it's now fixed, I'll make a PR for Larry to get this in 3.5.0rc2.

[larryhastings]

Pull request accepted and merged.

[python-dev]

New changeset 595614c08eeb by Yury Selivanov in branch '3.5':
Issue bpo-24867: Fix asyncio.Task.get_stack() for 'async def' coroutines
https://hg.python.org/cpython/rev/595614c08eeb

New changeset 9b28f41f1353 by Larry Hastings in branch '3.5':
Merged in 1st1/cpython350 (pull request #5)
https://hg.python.org/cpython/rev/9b28f41f1353

New changeset ad48d5a4ef40 by Larry Hastings in branch '3.5':
Add missing Misc/NEWS item for merged pull request for issue bpo-24867.
https://hg.python.org/cpython/rev/ad48d5a4ef40