zipfile broken with --without-threads

[Arfrever]

BPO	25364
Nosy	@Yhg1s, @serhiy-storchaka

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2015-10-10.16:46:23.543>
created_at = <Date 2015-10-10.15:45:02.007>
labels = ['type-bug', 'library']
title = 'zipfile broken with --without-threads'
updated_at = <Date 2015-10-10.16:46:23.542>
user = 'https://bugs.python.org/Arfrever'

bugs.python.org fields:

activity = <Date 2015-10-10.16:46:23.542>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2015-10-10.16:46:23.543>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2015-10-10.15:45:02.007>
creator = 'Arfrever'
dependencies = []
files = []
hgrepos = []
issue_num = 25364
keywords = ['3.5regression']
message_count = 3.0
messages = ['252720', '252727', '252728']
nosy_count = 5.0
nosy_names = ['twouters', 'alanmcintyre', 'Arfrever', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue25364'
versions = ['Python 3.5', 'Python 3.6']

[Arfrever]

zipfile module unconditionally requires threading module since revision 4973ccd46e32 (in Python >=3.5), which causes errors in over 50 Lib/test/test_*.py files.

[  1/399] test_cmd_line
test test_cmd_line crashed -- Traceback (most recent call last):
  File "/tmp/cpython/Lib/test/libregrtest/runtest.py", line 149, in runtest_inner
    the_module = importlib.import_module(abstest)
  File "/tmp/cpython/Lib/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 986, in _gcd_import
  File "<frozen importlib._bootstrap>", line 969, in _find_and_load
  File "<frozen importlib._bootstrap>", line 958, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 654, in exec_module
  File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
  File "/tmp/cpython/Lib/test/test_cmd_line.py", line 11, in <module>
    from test.support import script_helper
  File "/tmp/cpython/Lib/test/support/script_helper.py", line 14, in <module>
    import zipfile
  File "/tmp/cpython/Lib/zipfile.py", line 16, in <module>
    import threading
  File "/tmp/cpython/Lib/threading.py", line 4, in <module>
    import _thread
ImportError: No module named '_thread'

[python-dev]

New changeset 15740b3ad148 by Serhiy Storchaka in branch '3.5':
Issue bpo-25364: zipfile now works in threads disabled builds.
https://hg.python.org/cpython/rev/15740b3ad148

New changeset 44b37c3ee76c by Serhiy Storchaka in branch 'default':
Issue bpo-25364: zipfile now works in threads disabled builds.
https://hg.python.org/cpython/rev/44b37c3ee76c

[serhiy-storchaka]

Thank you for your report Arfrever.