Add a context manager to telnetlib.Telnet

[desbma]

BPO	25485
Nosy	@bitdancer, @berkerpeksag, @desbma, @matrixise
Files	issue25485.patch issue25485-2.patch issue25485-3.patch issue25485-4.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2015-11-28.17:27:24.660>
created_at = <Date 2015-10-26.18:20:19.145>
labels = ['type-feature', 'library']
title = 'Add a context manager to telnetlib.Telnet'
updated_at = <Date 2015-11-28.17:27:24.658>
user = 'https://github.com/desbma'

bugs.python.org fields:

activity = <Date 2015-11-28.17:27:24.658>
actor = 'r.david.murray'
assignee = 'none'
closed = True
closed_date = <Date 2015-11-28.17:27:24.660>
closer = 'r.david.murray'
components = ['Library (Lib)']
creation = <Date 2015-10-26.18:20:19.145>
creator = 'desbma'
dependencies = []
files = ['40879', '40902', '41106', '41119']
hgrepos = []
issue_num = 25485
keywords = ['patch']
message_count = 16.0
messages = ['253489', '253597', '253629', '253631', '253632', '253633', '253634', '253737', '253739', '253753', '254813', '254814', '255031', '255083', '255547', '255548']
nosy_count = 6.0
nosy_names = ['r.david.murray', 'SilentGhost', 'python-dev', 'berker.peksag', 'desbma', 'matrixise']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue25485'
versions = ['Python 3.6']

[desbma]

telnetlib.Telnet could have a context manager to call close() automatically.

I can provide a patch if the idea is approved, although I have never contributed to Python.

[berkerpeksag]

This seems like a reasonable request to me.

See https://docs.python.org/devguide/ to learn how to contribute to Python.

[matrixise]

Here is a small patch

[matrixise]

Maybe, modify the documentation or improve the current examples.

[SilentGhost]

This probably needs test

[matrixise]

totally agree, I will work on this issue tomorrow

[desbma]

I was actually writing a patch with a test, but since Stéphane beat me to it, I'll let him do the job :)

[matrixise]

New version of the patch, I have modified the 'test' function. In this function, I use the with statement with the __enter__ and __exit__.

[SilentGhost]

That's fine as a code change, but that's not the kind of test I meant. There is a Lib/test/test_ftplib.py and it basically needs test_with_statement added to one or few test cases. Have a look at how the similar functions implemented in Lib/test/.

[matrixise]

Ok i will submit an other patch for the tests and the documentation

On 30 oct. 2015, at 4:37 PM, SilentGhost <report@bugs.python.org> wrote:

SilentGhost added the comment:

That's fine as a code change, but that's not the kind of test I meant. There is a Lib/test/test_ftplib.py and it basically needs test_with_statement added to one or few test cases. Have a look at how the similar functions implemented in Lib/test/.

----------

---

Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue25485\>

---

[matrixise]

Should I develop a mock telnet server for the unittest ?

[bitdancer]

The existing tests seem to have at least some infrastructure that would apply here, so figuring out how to use/extend that is better than writing new code, I'd say.

[matrixise]

Need review for this new patch.

• Add test
• Improve the documentation
• Update the Misc/NEWS