Support Path objects in the posix module

[serhiy-storchaka]

BPO	26027
Nosy	@brettcannon, @pfmoore, @tjguk, @ethanfurman, @berkerpeksag, @vadmium, @zware, @serhiy-storchaka, @eryksun, @zooba, @JelleZijlstra
Dependencies	bpo-26671: Clean up path_converter in posixmodule.c bpo-26800: Don't accept bytearray as filenames part 2
Files	path_converter_path.patch issue27186-os_path_t.patch path_converter.diff: Inline of PyOS_FSPath() path_converter.diff: Updated patch since adding the warning about bytearrays path_converter.diff: Incorporate Serhiy's review feedback

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/brettcannon'
closed_at = <Date 2016-08-27.19:59:15.038>
created_at = <Date 2016-01-06.21:05:29.971>
labels = ['extension-modules', 'type-feature', 'OS-windows']
title = 'Support Path objects in the posix module'
updated_at = <Date 2016-09-06.22:59:12.215>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2016-09-06.22:59:12.215>
actor = 'python-dev'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2016-08-27.19:59:15.038>
closer = 'berker.peksag'
components = ['Extension Modules', 'Windows']
creation = <Date 2016-01-06.21:05:29.971>
creator = 'serhiy.storchaka'
dependencies = ['26671', '26800']
files = ['42382', '43238', '44029', '44090', '44159']
hgrepos = []
issue_num = 26027
keywords = ['patch']
message_count = 27.0
messages = ['257642', '262963', '267427', '269212', '269220', '269797', '269801', '272061', '272556', '272650', '272677', '273161', '273734', '273735', '273745', '273748', '273749', '273754', '273786', '273788', '273791', '273792', '273793', '273799', '273800', '274650', '274654']
nosy_count = 12.0
nosy_names = ['brett.cannon', 'paul.moore', 'tim.golden', 'ethan.furman', 'python-dev', 'berker.peksag', 'martin.panter', 'zach.ware', 'serhiy.storchaka', 'eryksun', 'steve.dower', 'JelleZijlstra']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue26027'
versions = ['Python 3.6']

[serhiy-storchaka]

path_converter should be changed to accept objects with the "path" attribute. See bpo-22570 for details.

[serhiy-storchaka]

Here is preliminary patch without tests. Writing tests will be tiresome.

[JelleZijlstra]

The patch is obsolete because PEP-519 ended up going with a different approach. I submitted a new patch for the path_t converter in bpo-27186. That patch probably fits better here, so I'm resubmitting it.

[brettcannon]

Did you still want to handle this, Serhiy, or should I assign the issue to myself?

[serhiy-storchaka]

I'll take a look.

[serhiy-storchaka]

At first glance bpo-27186-os_path_t.patch looks good.

But with the patch applied the error message in case of incorrect argument type is always "expected str, bytes or os.PathLike object, not ...". Currently it is more detailed and specific: contains the function and the argument names, and is aware that some functions accept an integer or None. I think the best way is to inline the code of PyOS_FSPath in path_converter.

Also we first resolve bpo-26800.

[brettcannon]

I have no issues inlining -- with a comment about the inlining -- if it buys us better error messages in this critical case.

[brettcannon]

Here is a version of Jelle's patch but with PyOS_FSPath() inlined.

Serhiy, does this work for you?

[brettcannon]

Here is an updated patch that adds in change to posixmodule.c stemming from the new warning about using bytearrays. It also makes type checking more stringent for what __fspath__() returns.

[serhiy-storchaka]

Added comments on Rietveld. Needed tests for supporting path-like objects. And it would be nice to have few tests for error messages.