Remove the Deprecated API in trace module

[orsenthil]

BPO	26069
Nosy	@abalkin, @orsenthil, @berkerpeksag, @Vgr255
Files	issue26069.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/orsenthil'
closed_at = <Date 2016-01-11.15:11:47.916>
created_at = <Date 2016-01-10.00:20:26.857>
labels = ['type-bug', 'library']
title = 'Remove the Deprecated API in trace module'
updated_at = <Date 2016-01-18.04:12:25.237>
user = 'https://github.com/orsenthil'

bugs.python.org fields:

activity = <Date 2016-01-18.04:12:25.237>
actor = 'python-dev'
assignee = 'orsenthil'
closed = True
closed_date = <Date 2016-01-11.15:11:47.916>
closer = 'orsenthil'
components = ['Library (Lib)']
creation = <Date 2016-01-10.00:20:26.857>
creator = 'orsenthil'
dependencies = []
files = ['41562']
hgrepos = []
issue_num = 26069
keywords = ['patch']
message_count = 11.0
messages = ['257877', '257881', '257883', '257884', '257965', '257966', '257967', '257968', '258174', '258446', '258497']
nosy_count = 5.0
nosy_names = ['belopolsky', 'orsenthil', 'python-dev', 'berker.peksag', 'abarry']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue26069'
versions = ['Python 3.6']

[orsenthil]

A number of old methods in trace module were deprecated in bpo-10371. They should be removed in 3.6 release.

[orsenthil]

This patch removes the deprecated apis from 3.6. After getting a review from one another core dev, I will commit this.

• No doc changes are required as the deprecated apis were not documented.
• README will be added during commit.

[Vgr255]

You seem to have forgotten to include a patch.

[orsenthil]

Sorry for that. Here is the patch.

[python-dev]

New changeset 6f05bdc18661 by Senthil Kumaran in branch 'default':
Issue bpo-26069: Remove the deprecated apis in the trace module.
https://hg.python.org/cpython/rev/6f05bdc18661

[orsenthil]

Thanks for the review, matrixise. I've submitted this change.

[berkerpeksag]

I couldn't find exact references, but I think we've reached an agreement that we want to keep old APIs in the stdlib to make porting from Python 2 easier. So you might want to revert this :)

[orsenthil]

Hi Berker, could you find the reference for it? It will be helpful to analyze.
IMO, the non-removal of 2.x-> 3.x APIs could be done on a case to case basis.

In this case, bpo-10371 made the change in (2010) of making the undocumented public methods to private internal and deprecated those old undocumented internal (but public) methods. It was a correct thing to do. Removal of the deprecated should have been done sooner. Otherwise, we are left with redundant methods (public and _private) in the same module serving no useful purpose.

[berkerpeksag]

Sorry, I don't have much time investigate this further, but here is a few references from my bookmarks:

• http://bugs.python.org/msg253473 (from bpo-20438)
• https://hg.python.org/peps/rev/570913685f49 (this doesn't mention old APIs, but I think we can safely follow it for old APIs)

Another discussions about deprecation policy: bpo-24203 (old threading API), bpo-25486 (inspect.getargspec()) and bpo-26041 (platform.dist() and platform.linux_distribution())

If you want to keep the old API removed, it would be great to add a note in Doc/whatsnew/3.6.rst in addtion to the Misc/NEWS entry.

[orsenthil]

Thanks for the pointers, Berker. That was very helpful and I will keep in mind when evaluating other deprecated apis.

For the trace module, I will add this removal information in Doc/whatsnew/3.6.rst

[python-dev]

New changeset 715d8a739f3b by Senthil Kumaran in branch 'default':
bpo-26069 - Update whatsnew/3.6.rst on traceback module's api removals.
https://hg.python.org/cpython/rev/715d8a739f3b