freeze.py makefile uses the wrong flags variables

[DanielShaulov]

BPO	26271
Nosy	@Yhg1s, @brettcannon, @moreati
Files	pyflags.patch: add PY_ to all FLAGS

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/brettcannon'
closed_at = <Date 2016-03-18.17:31:03.175>
created_at = <Date 2016-02-02.23:02:15.737>
labels = ['type-bug', 'build']
title = 'freeze.py makefile uses the wrong flags variables'
updated_at = <Date 2016-03-18.17:31:03.174>
user = 'https://bugs.python.org/DanielShaulov'

bugs.python.org fields:

activity = <Date 2016-03-18.17:31:03.174>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2016-03-18.17:31:03.175>
closer = 'brett.cannon'
components = ['Build']
creation = <Date 2016-02-02.23:02:15.737>
creator = 'Daniel Shaulov'
dependencies = []
files = ['41785']
hgrepos = []
issue_num = 26271
keywords = ['patch']
message_count = 5.0
messages = ['259444', '261075', '261224', '261979', '261980']
nosy_count = 5.0
nosy_names = ['twouters', 'brett.cannon', 'python-dev', 'Alex.Willmer', 'Daniel Shaulov']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue26271'
versions = ['Python 3.5', 'Python 3.6']

[DanielShaulov]

Tools/Freeze/makemakefile.py uses CFLAGS, LDFLAGS and CPPFLAGS instead of the PY_ prefixed versions. This makes flags passed to ./configure ineffective.

The patch makes the trivial fix of adding PY_ when needed.

[DanielShaulov]

Pinging after a month without review (as the devguide suggests).

[brettcannon]

Quick review suggests Daniel's patch does the right thing (based on Tools/freeze/test and looking at the generated Makefile which has PY_LDFLAGS defined).

Don't have time to commit it right now, but I will in the near future.

[python-dev]

New changeset 599328247e84 by Brett Cannon in branch '3.5':
Issue bpo-26271: Fix the Freeze tool to use variables passed in from the
https://hg.python.org/cpython/rev/599328247e84

New changeset 364895e54bb0 by Brett Cannon in branch 'default':
Merge for issue bpo-26271
https://hg.python.org/cpython/rev/364895e54bb0

[brettcannon]

Thanks for the patch, Daniel! Added you to the ACKS file.