Probable typo in Arg Clinic's linear_format()

[vadmium]

BPO	26316
Nosy	@vstinner, @larryhastings, @vadmium

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-02-14.04:35:14.046>
created_at = <Date 2016-02-09.02:32:33.807>
labels = ['expert-argument-clinic']
title = "Probable typo in Arg Clinic's linear_format()"
updated_at = <Date 2016-02-14.04:35:14.045>
user = 'https://github.com/vadmium'

bugs.python.org fields:

activity = <Date 2016-02-14.04:35:14.045>
actor = 'martin.panter'
assignee = 'none'
closed = True
closed_date = <Date 2016-02-14.04:35:14.046>
closer = 'martin.panter'
components = ['Argument Clinic']
creation = <Date 2016-02-09.02:32:33.807>
creator = 'martin.panter'
dependencies = []
files = []
hgrepos = []
issue_num = 26316
keywords = []
message_count = 5.0
messages = ['259908', '259912', '260050', '260260', '260262']
nosy_count = 4.0
nosy_names = ['vstinner', 'larry', 'python-dev', 'martin.panter']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue26316'
versions = ['Python 3.5', 'Python 3.6']

[vadmium]

The curly bracket separator is assigned to “curl”, but then the previous “curly” variable is tested:

https://hg.python.org/cpython/annotate/3.5/Tools/clinic/clinic.py#l202

name, curl, trailing = trailing.partition('}')
if not curly or name not in kwargs:
...

I presume the fix is to assign to “curly”, but I haven’t had a chance to figure out how to test it yet.

[larryhastings]

Yeah, change "curl" to "curly". If you commit the fix without a test case I'd forgive you. Or I can do it if that makes you nervous.

[vstinner]

Go ahead.

[python-dev]

New changeset aec2eae8933e by Martin Panter in branch '3.5':
Issue bpo-26316: Fix variable name typo in Argument Clinic
https://hg.python.org/cpython/rev/aec2eae8933e

New changeset 6c122e4e1cb2 by Martin Panter in branch 'default':
Issue bpo-26316: Merge Arg Clinic fix from 3.5
https://hg.python.org/cpython/rev/6c122e4e1cb2

[vadmium]

I did look into testing, but I gave up. :) The test file doesn’t even import. I got the following error (without exception or traceback), cause by the line that reads “c = clinic.Clinic(language='C')”:

$ (cd Tools/clinic/ && ../../python clinic_test.py)
Error:
Destination does not exist: 'file'
[Exit 255]