Add optional source parameter to warnings.warn()

[vstinner]

BPO	26604
Nosy	@vstinner
Files	warnings_warn_source.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-03-22.23:56:48.369>
created_at = <Date 2016-03-21.16:18:33.368>
labels = ['type-feature']
title = 'Add optional source parameter to warnings.warn()'
updated_at = <Date 2016-03-22.23:56:48.368>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2016-03-22.23:56:48.368>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2016-03-22.23:56:48.369>
closer = 'vstinner'
components = []
creation = <Date 2016-03-21.16:18:33.368>
creator = 'vstinner'
dependencies = []
files = ['42236']
hgrepos = []
issue_num = 26604
keywords = ['patch']
message_count = 3.0
messages = ['262137', '262138', '262217']
nosy_count = 2.0
nosy_names = ['vstinner', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue26604'
versions = ['Python 3.6']

[vstinner]

Follow-up of the issue bpo-26567 which added PyErr_ResourceWarning() (C API), attached patch adds a new source parameter to the warnings.warn() function (Python API).

source is the destroyed object which emits a ResourceWarning. The source is used to show the traceback where the object was created (allocated) when tracemalloc is used.

The patch also changes _pyio, asyncio and asyncore modules to set the source parameter.

Note: tempfile doesn't set source because it uses a class method:

    @classmethod
    def _cleanup(cls, name, warn_message):
        _shutil.rmtree(name)
        _warnings.warn(warn_message, ResourceWarning)

[vstinner]

For asyncio, it should help to fix the ResourceWarning warnings on AIX (which has a broken ssl module):

http://buildbot.python.org/all/builders/PPC64%20AIX%203.x/builds/4700/steps/test/logs/stdio

test_create_server_ssl_verify_failed (test.test_asyncio.test_events.PollEventLoopTests) ... FAIL
/home/shager/cpython-buildarea/3.x.edelsohn-aix-ppc64/build/Lib/unittest/case.py:628: ResourceWarning: unclosed <socket.socket fd=22, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('127.0.0.1', 55439)>
outcome.errors.clear()

[python-dev]

New changeset 3a57ced47459 by Victor Stinner in branch 'default':
Add a source parameter to warnings.warn()
https://hg.python.org/cpython/rev/3a57ced47459