recursive_repr forgets to override __qualname__ of wrapper

[zhangyangyu]

BPO	26634
Nosy	@rhettinger, @serhiy-storchaka, @zhangyangyu
Files	qualname_of_recursive_repr_in_reprlib.patch qualname_of_recursive_repr_in_reprlib_v2.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2016-04-26.06:32:05.471>
created_at = <Date 2016-03-24.04:09:36.638>
labels = ['type-bug', 'library']
title = 'recursive_repr forgets to override __qualname__ of wrapper'
updated_at = <Date 2016-04-26.06:32:05.470>
user = 'https://github.com/zhangyangyu'

bugs.python.org fields:

activity = <Date 2016-04-26.06:32:05.470>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2016-04-26.06:32:05.471>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2016-03-24.04:09:36.638>
creator = 'xiang.zhang'
dependencies = []
files = ['42266', '42268']
hgrepos = []
issue_num = 26634
keywords = ['patch']
message_count = 5.0
messages = ['262326', '262327', '262329', '264048', '264218']
nosy_count = 4.0
nosy_names = ['rhettinger', 'python-dev', 'serhiy.storchaka', 'xiang.zhang']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'commit review'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue26634'
versions = ['Python 3.5', 'Python 3.6']

[zhangyangyu]

In reprlib.recursive_repr, it seems __qualname__ is forgotten. Giving the example in reprlib document, it gives a strange result 'recursive_repr.<locals>.decorating_function.<locals>.wrapper' of Mylist.__repr__.__qualname__.

I simply add the assignment of __qualname__. But I doubt the treatment of __module__, __doc__, __name__, __qualname__ will raise AttributeError when they don't exist in user_function. Is this the desired behaviour or we'd better treat them like functools.update_wrapper, catch and then ignore the error.

[rhettinger]

FWIW, qualname was invented *after* recursive_repr, so it would be more accurate to say that qualname forgot recursive_repr :-)

If you don't mind, please add a test to your patch.

[zhangyangyu]

Hi, Raymond, I've added the test to test the assigned attributes.
I use WRAPPER_ASSIGNMENTS in functools so we can keep them consistent. I don't know how to get the original func from the already decorated methods in this case so I define a new container.
If there are mistakes or better solution, I am willing to know.

[serhiy-storchaka]

LGTM. I would commit the patch to 3.5 too.

[python-dev]

New changeset 1f0369547b0e by Serhiy Storchaka in branch '3.5':
Issue bpo-26634: recursive_repr() now sets __qualname__ of wrapper.
https://hg.python.org/cpython/rev/1f0369547b0e

New changeset fb70ea8b7b2d by Serhiy Storchaka in branch 'default':
Issue bpo-26634: recursive_repr() now sets __qualname__ of wrapper.
https://hg.python.org/cpython/rev/fb70ea8b7b2d