assertSequenceEqual() raises BytesWarning when format message

[serhiy-storchaka]

BPO	26837
Nosy	@rbtcollins, @ezio-melotti, @voidspace, @vadmium, @serhiy-storchaka
Files	unittest_assert_bytes_warning.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2016-04-25.06:01:04.513>
created_at = <Date 2016-04-24.15:32:26.204>
labels = ['tests', 'type-bug', 'library']
title = 'assertSequenceEqual() raises BytesWarning when format message'
updated_at = <Date 2016-04-25.06:01:04.511>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2016-04-25.06:01:04.511>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2016-04-25.06:01:04.513>
closer = 'serhiy.storchaka'
components = ['Library (Lib)', 'Tests']
creation = <Date 2016-04-24.15:32:26.204>
creator = 'serhiy.storchaka'
dependencies = []
files = ['42581']
hgrepos = []
issue_num = 26837
keywords = ['patch']
message_count = 4.0
messages = ['264110', '264137', '264154', '264155']
nosy_count = 6.0
nosy_names = ['rbcollins', 'ezio.melotti', 'michael.foord', 'python-dev', 'martin.panter', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue26837'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']

[serhiy-storchaka]

assertSequenceEqual() raises BytesWarning when format failure report. See for example http://buildbot.python.org/all/builders/AMD64%20OpenIndiana%203.x/builds/10575/steps/test/logs/stdio :

======================================================================
ERROR: test_close_fds_0_1 (test.test_subprocess.POSIXProcessTestCase)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/export/home/buildbot/64bits/3.x.cea-indiana-amd64/build/Lib/test/test_subprocess.py", line 1741, in test_close_fds_0_1
    self.check_close_std_fds([0, 1])
  File "/export/home/buildbot/64bits/3.x.cea-indiana-amd64/build/Lib/test/test_subprocess.py", line 1727, in check_close_std_fds
    self.assertEqual((out, err), (b'apple', b'orange'))
  File "/export/home/buildbot/64bits/3.x.cea-indiana-amd64/build/Lib/unittest/case.py", line 820, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/export/home/buildbot/64bits/3.x.cea-indiana-amd64/build/Lib/unittest/case.py", line 1029, in assertTupleEqual
    self.assertSequenceEqual(tuple1, tuple2, msg, seq_type=tuple)
  File "/export/home/buildbot/64bits/3.x.cea-indiana-amd64/build/Lib/unittest/case.py", line 967, in assertSequenceEqual
    (i, item1, item2))
BytesWarning: str() on a bytes instance

======================================================================

Proposed patch fixes message formatting and adds tests for assertions that can emit BytesWarning.

[vadmium]

I think the change is good in spirit, especially using repr() and limiting the size. See the review for a couple problems.

[python-dev]

New changeset ae5cc8ab664a by Serhiy Storchaka in branch '3.5':
Issue bpo-26837: assertSequenceEqual() now correctly outputs non-stringified
https://hg.python.org/cpython/rev/ae5cc8ab664a

New changeset d0d541c2afb7 by Serhiy Storchaka in branch '2.7':
Issue bpo-26837: assertSequenceEqual() now correctly outputs non-stringified
https://hg.python.org/cpython/rev/d0d541c2afb7

[serhiy-storchaka]

Thank you for your helpful review Martin!