setting SO_REUSEPORT fails at API 21

[xdegaye]

BPO	26858
Nosy	@gvanrossum, @vstinner, @giampaolo, @pjenvey, @xdegaye, @Fak3, @1st1, @moreati, @yan12125
Dependencies	bpo-27027: add the 'is_android' attribute to test.support
Files	test.asyncio.patch test.asyncio_2.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2016-04-26.13:37:22.784>
labels = ['type-bug', '3.7', 'expert-asyncio']
title = 'setting SO_REUSEPORT fails at API 21'
updated_at = <Date 2017-12-10.14:24:43.827>
user = 'https://github.com/xdegaye'

bugs.python.org fields:

activity = <Date 2017-12-10.14:24:43.827>
actor = 'xdegaye'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['asyncio']
creation = <Date 2016-04-26.13:37:22.784>
creator = 'xdegaye'
dependencies = ['27027']
files = ['42610', '42940']
hgrepos = []
issue_num = 26858
keywords = ['patch']
message_count = 22.0
messages = ['264281', '264602', '264605', '264635', '264653', '264662', '264666', '264690', '265928', '266061', '276615', '285392', '285394', '285402', '285406', '302351', '302357', '304704', '304708', '307947', '307950', '307960']
nosy_count = 9.0
nosy_names = ['gvanrossum', 'vstinner', 'giampaolo.rodola', 'pjenvey', 'xdegaye', 'Roman.Evstifeev', 'yselivanov', 'Alex.Willmer', 'yan12125']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue26858'
versions = ['Python 3.6', 'Python 3.7']

[xdegaye]

Android defines SO_REUSEPORT on android API 21 but setting this option in the asyncio tests raises OSError: [Errno 92] Protocol not available.

The attached patch assumes there is a platform.android_ver() function to detect that this is the android platform. The patch does not take into account the fact that this may be fixed in future versions of android.

[gvanrossum]

Where is the patch that adds android_ver()? At the very least that should be listed as a dependency here.

I don't very much like to have changes to asyncio that can only work in Python 3.6; there's still an upstream version (https://github.com/python/asyncio) that is used to do PyPI releases of asyncio for Python 3.3. I try to keep that in sync with the stdlib on all platforms, otherwise figuring out whether any changes need to be packported is a nightmare.

You might also update the comment somewhere that currently states that reuse_port is not supported on Windows.

PS. It amuses me that each platform apparently has a different way to check (there are three different types of platform checks in the lines you change).

[yan12125]

Where is the patch that adds android_ver()?

http://bugs.python.org/issue26855

Xavier de Gaye's implementation is buggy while works for most cases.

[xdegaye]

The patch was not intended to be proposed as a way to fix this problem, but as an indication of what the problem is. This issue is a dependency of issue bpo-26865: Meta-issue: support of the android platform.

I should have posted instead the result of running 'python -m test -v test_asyncio' on an android emulator running an x86 system image at API level 21, which is:

======================================================================
ERROR: test_create_datagram_endpoint_sockopts (test.test_asyncio.test_base_events.BaseEventLoopWithS
electorTests)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.6/test/test_asyncio/test_base_events.py", line 1506,
 in test_create_datagram_endpoint_sockopts
    socket.SOL_SOCKET, socket.SO_REUSEPORT))
OSError: [Errno 92] Protocol not available

======================================================================
ERROR: test_create_server_reuse_port (test.test_asyncio.test_events.EPollEventLoopTests)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.6/test/test_asyncio/test_events.py", line 830, in te
st_create_server_reuse_port
    socket.SOL_SOCKET, socket.SO_REUSEPORT))
OSError: [Errno 92] Protocol not available

======================================================================
ERROR: test_create_server_reuse_port (test.test_asyncio.test_events.PollEventLoopTests)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.6/test/test_asyncio/test_events.py", line 830, in te
st_create_server_reuse_port
    socket.SOL_SOCKET, socket.SO_REUSEPORT))
OSError: [Errno 92] Protocol not available

======================================================================
ERROR: test_create_server_reuse_port (test.test_asyncio.test_events.SelectEventLoopTests)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.6/test/test_asyncio/test_events.py", line 830, in te
st_create_server_reuse_port
    socket.SOL_SOCKET, socket.SO_REUSEPORT))
OSError: [Errno 92] Protocol not available

---

Ran 991 tests in 16.528s

FAILED (errors=4, skipped=2)
test test_asyncio failed
1 test failed:
test_asyncio
Total duration: 0:00:18

[gvanrossum]

OK, I'll wait until Android support is closer. Do you have a core dev who's mentoring/reviewing here?

[xdegaye]

Stefan has already commited and closed some of the issues listed at issue bpo-26865. Martin has closed issue bpo-22359, a blocker for the cross-compilation of python.

I will enter an issue for all the failures listed at https://bitbucket.org/xdegaye/pyona/wiki/testsuite and add them to the list in the android meta-issue.

[gvanrossum]

If there are a lot of Android issue maybe you could get a tracker manager
to add a new keyword or category or whatever?

[xdegaye]

Running the "Search" button on the tracker with "Components" set as "Cross-Build" lists 42 issues (20 in the last year).

I guess using this existing category is fine if the titles' issues are prefixed with "android:".

[xdegaye]

Should use boolean 'is_android' being added to module test.support by issue bpo-27027, instead of platform.android_ver()[0].

[xdegaye]

New patch test.asyncio_2.patch uses test.support.is_android and adds a dependency to issue bpo-27027.

[1st1]

This issue was fixed in bpo-28174.